Bug 373114 - KRearrangeColumnsProxyModel isn't following the model protocol
Summary: KRearrangeColumnsProxyModel isn't following the model protocol
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kitemmodels
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.28.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-30 15:30 UTC by Emmanuel Lepage Vallée
Modified: 2021-08-25 11:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
patch (1.21 KB, patch)
2016-11-30 15:31 UTC, Emmanuel Lepage Vallée 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Emmanuel Lepage Vallée 2016-11-30 15:30:41 UTC 
When the columns are changed at runtime, the views are badly confused. Also, not using the parent index in some methods break trees, but I don't care much about that.

Here is a patch to fix the worst issue. I can push it.
Comment 1 Emmanuel Lepage Vallée 2016-11-30 15:31:58 UTC 
Created attachment 102549 [details]
patch
Comment 2 Christoph Feck 2016-11-30 15:51:53 UTC 
Please create a review request for your patch, either on https://phabricator.kde.org/differential/ or https://git.reviewboard.kde.org/

The patch has multiple coding style issues, and these are best discussed with our code reviewing tools.
Comment 3 Emmanuel Lepage Vallée 2016-11-30 16:14:57 UTC 
Done https://phabricator.kde.org/D3548
Comment 4 David Faure 2020-04-15 07:40:14 UTC 
https://phabricator.kde.org/D27876 landed meanwhile.
Comment 5 Ahmad Samir 2021-08-25 11:19:23 UTC 
Closing per comment#4.