Bug 373093 - Search / Find box unreadable when using dark theme
Summary: Search / Find box unreadable when using dark theme
Status: RESOLVED DUPLICATE of bug 373764
Alias: None
Product: frameworks-ktexteditor
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.28.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-29 23:39 UTC by Janek Bevendorff
Modified: 2017-02-19 15:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Find in document, matches found (6.66 KB, image/png)
2016-11-29 23:39 UTC, Janek Bevendorff
Details
Find in document: no matches found (7.07 KB, image/png)
2016-11-29 23:39 UTC, Janek Bevendorff
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Janek Bevendorff 2016-11-29 23:39:32 UTC
Created attachment 102530 [details]
Find in document, matches found

When searching for text inside a document (Ctrl+F) the text inside the search / find box becomes unreadable when using a dark UI theme (see screenshots). The reason for this is that the background color is changed to either a light green or light red, but the text color is the default theme color. This works for bright themes with black text, but not at all for dark themes with white text.
Comment 1 Janek Bevendorff 2016-11-29 23:39:47 UTC
Created attachment 102531 [details]
Find in document: no matches found
Comment 2 Sven Brauch 2016-11-29 23:51:56 UTC
Changing product to frameworks-ktexteditor, the issue is there.
Comment 3 Dominik Haumann 2017-02-18 12:15:31 UTC
It works for me for Breeze Dark, so I cannot reproduce. Which color scheme do you use exactly? For me, the green and red are very dark, so readability is very good compared to your example. So from my perspective, this is fixed...?

Please also try again with KDE Frameworks 5.31.
Comment 4 Janek Bevendorff 2017-02-18 12:49:14 UTC
I'm using the latest Git revision of KDevelop/KDevplatform on KF 5.30. I
have the issue with both the Breeze Dark theme as well as the Krita Dark
theme by David Revoy.
Comment 5 Sven Brauch 2017-02-18 13:29:29 UTC
This only happens when switching color-scheme at runtime from within the application, fix should be this: https://phabricator.kde.org/D4637
Comment 6 Janek Bevendorff 2017-02-18 21:27:17 UTC
No, it does not. This is permanent.
Comment 7 Sven Brauch 2017-02-18 22:43:53 UTC
Did you select the color scheme in KDevelop's Settings menu or in systemsettings?
Comment 8 Janek Bevendorff 2017-02-18 22:48:26 UTC
I did set it in the application. So if with "runtime switching" you also mean the program restoring the color theme at startup, then your observation is correct.
The problem, however, is not that I changed the setting at runtime and it would be gone after a full restart (like those artifacts that often appear when switching Plasma themes where certain UI elements keep their old appearance until I restart my session).
Comment 9 Sven Brauch 2017-02-19 01:21:43 UTC
Yes, sorry, bad phrasing from my side; still the issue addressed in the linked RR.
Comment 10 Sven Brauch 2017-02-19 01:22:45 UTC
To clarify what I meant, setting it in the application still switches "at runtime", just automatically at each startup, and thus has the same issue in this case.
Comment 11 Dominik Haumann 2017-02-19 13:16:43 UTC
In this case, this is a duplicate of bug #373764, right ?
Comment 12 Sven Brauch 2017-02-19 15:37:37 UTC
Yes. Marking this as duplicate as the other one contains more specific information.

*** This bug has been marked as a duplicate of bug 373764 ***