Bug 373072 - project is one frame too long
Summary: project is one frame too long
Status: RESOLVED WORKSFORME
Alias: None
Product: kdenlive
Classification: Applications
Component: Rendering & Export (other bugs)
Version First Reported In: 17.08.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-29 12:45 UTC by Martin
Modified: 2021-04-23 04:33 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:
fritzibaby: timeline_corruption+


Attachments
patch to fix project length (2.69 KB, patch)
2016-12-03 12:59 UTC, Martin
Details
Extra black frame at the end of the project (73.08 KB, application/xml)
2017-08-30 19:11 UTC, Assa Daf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin 2016-11-29 12:45:35 UTC
add a color clip to a new project and change the length to be eg. 10 frames. When you add the clip to the timeline, it reaches from 00:00:00:00 to 00:00:00:09 (10 frames), but the project has one frame more (00:00:00:10), so when you play it back or render the full project, you get one extra black frame at the end.
Comment 1 Martin 2016-12-03 12:59:18 UTC
Created attachment 102592 [details]
patch to fix project length

I tried to fix the bug myself by adjusting Render::mltCheckLength to set the "out" time to "duration - 1", which should be correct, if the first frame is "0".
With the patch, the problem is solved for me, I am not sure though if there are other points in the code where this also needs to be changed.
Comment 2 Jean-Baptiste Mardelle 2016-12-04 16:55:39 UTC
Git commit 9869d0b0cd75958cf2de3b53a57d578887dd7ba2 by Jean-Baptiste Mardelle.
Committed on 04/12/2016 at 16:37.
Pushed by mardelle into branch 'Applications/16.12'.

Fix black frame at end when rendering full project

M  +3    -4    src/dialogs/renderwidget.cpp
M  +9    -12   src/mainwindow.cpp

https://commits.kde.org/kdenlive/9869d0b0cd75958cf2de3b53a57d578887dd7ba2
Comment 3 Martin 2016-12-04 21:00:18 UTC
I can confirm that after the fix, the rendering output no longer has an additional black frame at the end.
In the interface however the project still has that frame, but I assume that is intentional.
Comment 4 Jean-Baptiste Mardelle 2016-12-04 21:02:33 UTC
Thanks for your confirmation. And yes, the last black frame in UI is intentional, it is necessary to allow some editing features.
Comment 5 Cyril Giraud 2017-05-26 18:37:44 UTC
Kdenlive 16.12.3: problem still present, but last frame is not black, but with same color than clip color.
Exporting full project or exporting selected zone makes same extra frame.
Comment 6 Assa Daf 2017-08-30 19:11:44 UTC
Created attachment 107598 [details]
Extra black frame at the end of the project

Hello
Attached simple blckframe.kdenlive project file that has that extra frame at the end after the last clip. Removing the last clip, the extra frame does not disappear but is still there after the new last clip.

kdenlive 17.08, opensuse leap 42.3 amd64
Comment 7 Julius Künzel 2021-03-24 13:01:47 UTC
Can you please update to the latest version (20.12.3 at the moment, https://kdenlive.org/en/download/) and report here whether this is still happening?

If this persists please check if it is might related to this bug 425960 especially this comment: https://bugs.kde.org/show_bug.cgi?id=425960#c10
Comment 8 Bug Janitor Service 2021-04-08 04:33:25 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2021-04-23 04:33:14 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!