Bug 373037 - Color picking in Freehand Path Tool
Summary: Color picking in Freehand Path Tool
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Vector (show other bugs)
Version: 3.0.1.1
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 418812 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-28 15:57 UTC by Kjartan Tysdal
Modified: 2020-05-23 08:10 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/krita/commit/5ec68b37737d383bb906488ed52b350e5525a95b
Version Fixed In:
kdebugtracking: Usability+

Attachments
screenshot showing the problem in Krita (124.58 KB, image/jpeg)
2016-11-28 15:57 UTC, Kjartan Tysdal 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Kjartan Tysdal 2016-11-28 15:57:32 UTC 
Created attachment 102503 [details]
screenshot showing the problem in Krita

When you color pick with Ctrl+LeftMouse while in the Freehand Path Tool then that click will affects your line when you start drawing. It creates an unwanted straight line from where you color picked (You can see what I mean in the attachment image).

best regards,
Kjartan Tysdal

PS. thanks a lot for Krita. I've been using it quite a lot lately and I find it be be really nice to work in.
Comment 1 Halla Rempt 2016-12-07 14:19:53 UTC 
Hi Kjartan,

Thanks for your report. I can confirm the issue. Now I only need to figure out how to fix it :-)
Comment 2 Halla Rempt 2016-12-07 14:21:04 UTC 
The same problem can be seen with the other path tools, like the bezier curve tool.
Comment 3 kdebugtracking 2020-03-13 11:52:03 UTC 
*** Bug 418812 has been marked as a duplicate of this bug. ***
Comment 4 kdebugtracking 2020-03-13 12:32:34 UTC 
Yep, still a thing.
Reproduced on 4.2.8 and 4.2.9-beta on Windows 10.
Comment 5 sh_zam 2020-05-23 08:10:02 UTC 
Git commit 5ec68b37737d383bb906488ed52b350e5525a95b by Sharaf Zaman.
Committed on 23/05/2020 at 08:09.
Pushed by szaman into branch 'krita/4.3'.

Fix Color picking in Freehand Path Tool and Bezier Curve tool

This bug was caused because the tools weren't using the usual
design. So, when the user would use color picker it would
send `beginPrimaryAction` to color picker, but also send
`mousePressEvent` to the primary tool.

M  +15   -9    plugins/tools/basictools/kis_tool_path.cc
M  +7    -3    plugins/tools/basictools/kis_tool_path.h
M  +24   -2    plugins/tools/basictools/kis_tool_pencil.cc
M  +7    -0    plugins/tools/basictools/kis_tool_pencil.h

https://invent.kde.org/graphics/krita/commit/5ec68b37737d383bb906488ed52b350e5525a95b