Bug 372906 - Brush color changes after color picking with a noticeable delay
Summary: Brush color changes after color picking with a noticeable delay
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (show other bugs)
Version: 3.0.1.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-25 02:55 UTC by katearcher89
Modified: 2023-12-04 19:54 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description katearcher89 2016-11-25 02:55:12 UTC
Currently when drawing in krita large images(I assume it is always the issue but it became noticeable when krita slows down to a certain degree) a brush color changes with a delay after color picking i.e. you do color picking with a hotkey, see the pick up popup and a change of color in brushes panel(to a new one) but if you will start to make strokes just the moment after a pick up the stroke will be in a color that was selected _before_ a color picking process was done(the newly selected color will be applied to the stroke _after_ you will stop that first stroke and start the second one or if you will wait for some time, a second or something like that) and it's annoying as hell.

How to reproduce:
0. Use a large image(5k-6r is fine I guess, krita starts to be laggy at that sizes, sadly)
1. Choose a brush(preferably a bigger one) and a color to draw
2. Start drawing
3. Pick a color via hotkey(I'm using alt + click)
4. See the changed color in brush properties and via color picker popup
5. Start a stroke with a brush immediately.
6. Get a stroke with a color from step 1 instead of step 4(through you will see that a brush properties shows you your newly picked up color)

Reproducible in krita 3.0, 3.0.1, 3.0.1.1 on three different windows instalations(both win7 and win10)

I suppose this is happening all the time(not only on big files) but when krita becomes even a little laggy this behaviour is already kicks in and in my case it is ruining my workflow quite a bit. It is can be fixed by lowering a lag, but I suppose a slowing down is a separate issue with Krita(although it is a little strange since I have i7 and 16gb ram and it should not be the issue but it is).
Comment 1 Halla Rempt 2016-12-07 14:30:34 UTC
Hi Kate,

I'm sorry, but I haven't been able to reproduce :-(. But I also don't experience lagginess, not even with 7000x8000 images and a 1000px brush. (Well, not with instant preview enabled.) I'm testing with the latest 3.1 release candidate, which is a bit newer than 3.0.1.1, but I also have never seen it with earlier releases.
Comment 2 Halla Rempt 2016-12-07 14:33:35 UTC
Hi,

At least two other people have reported that they've seen the same issue, so we can confirm.
Comment 3 Dmitry Kazakov 2016-12-12 10:49:35 UTC
I can confirm. It happens only when Instant preview is disabled and you pick before the calculation of the previous stroke is finished. 

The problem happens because since recently color picking is a stroke as well, therefore the picking itself is postponed till the previous stroke is finished. Therefore, the global color will change only when the previous stroke has been completed.
Comment 4 Dmitry Kazakov 2016-12-12 10:50:26 UTC
Added to phabricator:

https://phabricator.kde.org/T4879
Comment 5 katearcher89 2016-12-13 00:14:58 UTC
(In reply to Dmitry Kazakov from comment #3)
> I can confirm. It happens only when Instant preview is disabled and you pick
> before the calculation of the previous stroke is finished. 
> 
> The problem happens because since recently color picking is a stroke as
> well, therefore the picking itself is postponed till the previous stroke is
> finished. Therefore, the global color will change only when the previous
> stroke has been completed.

Actually no, in my case it happens regardless if instant preview is on or off. I've turn it on and tried to repeat the steps and yes, it still happens with instant preview on.
Comment 6 katearcher89 2016-12-20 23:52:15 UTC
(In reply to Boudewijn Rempt from comment #1)
> Hi Kate,
> 
> I'm sorry, but I haven't been able to reproduce :-(. But I also don't
> experience lagginess, not even with 7000x8000 images and a 1000px brush.
> (Well, not with instant preview enabled.) I'm testing with the latest 3.1
> release candidate, which is a bit newer than 3.0.1.1, but I also have never
> seen it with earlier releases.

A little more information about laggy Krita. It turns out Krita was running with default intel HD 530 graphic card(I have two on my desktop, one is nvidia and the other one is intel obviously). And with intel card I experience noticeable lags(which weren't there in krita 2.9.11), but with gtx960 I have no lags at all(no wonder though). Hope this information helps.
Comment 7 Rastaban26 2019-01-27 13:52:33 UTC
I would like to add few of my own observations:


I confirm:
----------
1. It happens also for me.
2. It happens with big images.
3. It lags when using color picking via hotkey (alternative invocation of brush tool)
4. Drawing immediately after picking color is impossible, often Krita needs time to apply selected color and puts a stroke with previous color.
5. It happens with instant preview turned on.


My own observations:
--------------------
1. Number of layers has direct influence on the lag in my case. 12 layers (filled with random stuff) with resolution 3840 x 2160 creates a noticeable lag in my case (although I don't have a powerful computer)
2. With the same set up (12 layers, res 3840 x 2160) color picking using color selector tool (default shortcut: P) works without any lag.


Annoying workaround:
--------------------
To pick a color:
1. Switch to color selector tool.
2. Pick a color.
3. Switch back to brush.
4. Paint.


Conclusion:
-----------
I think the hardware doesn't seem to be the problem in my case. Since color picking using color selector tool works without any problems. Only color picking via alternative invocation of brush tool with instant preview creates the lag.
Comment 8 Dynline 2023-12-04 19:54:06 UTC
I want to add this info that is helping me: I'm on windows an using full screen mode makes this problem better. It still happens, but more rarely.  

In my case I see this when working in 16 bit, where I have more performance issues.