Bug 372843 - Voice navigation improperly configured for audio output ("Text instructions" passed to phonon instead of "audio file URL")
Summary: Voice navigation improperly configured for audio output ("Text instructions" ...
Status: RESOLVED WORKSFORME
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 2.1 (KDE Applications 16.12)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-23 17:42 UTC by rinaldorexg
Modified: 2022-11-26 05:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rinaldorexg 2016-11-23 17:42:28 UTC
Overview: 

Instead of audio file url, the instruction is being passed to the phonon output and this makes it not play the voice instructions. 

I think this is actually a feature bug which directly hinders the voice navigation ability of marble. 

Build date: Today, on Linux. (Compiled from source in GitHub, KDE/marble - master branch)

Bug location: 
For your notice, 

https://github.com/KDE/marble/blob/master/src/plugins/render/routing/AudioOutput.cpp 

This is the source file where the potential bug resides. In line 87 as of now. For convenience, 

void AudioOutputPrivate::playInstructions()
{
    setupAudio();
    if ( m_output ) {
        m_output->enqueue( QUrl::fromLocalFile( m_voiceNavigation.instruction() ) );
        m_output->play();
    }
}

VoiceNavigation.cpp gives not the url, but the instruction as per the definition in https://github.com/KDE/marble/blob/master/src/lib/marble/routing/VoiceNavigationModel.cpp - line 407 as of now. 

QString VoiceNavigationModel::instruction() const
{
    return d->m_announcementText;
}
Expected output: Audio instructions need to played as per directions. 
Current output: None. Audio doesn't play because audio file url is not received. Only instruction is received as such.
Comment 1 Justin Zobel 2022-10-27 02:48:31 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 2 Bug Janitor Service 2022-11-11 05:19:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2022-11-26 05:16:48 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!