Bug 372788 - src/core/kfileitem.cpp is still using QFile::symLinkTarget() to get the target of the symbolic link.
Summary: src/core/kfileitem.cpp is still using QFile::symLinkTarget() to get the targe...
Status: ASSIGNED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.28.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: taro yamada
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-22 14:26 UTC by taro yamada
Modified: 2018-08-22 20:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description taro yamada 2016-11-22 14:26:26 UTC 
This is related to https://bugs.kde.org/show_bug.cgi?id=352927.
src/ioslaves/file/file.cpp has been fixed by using readlink instead of symlinkTarget(), but src/core/kfileitem.cpp still uses QFile::symLinkTarget().

For that reason, under certain circumstances, Dolphin's properties dialog will show the target of the symbolic link as an absolute path even though it is actually a relative path.

Is it ok to copy the same code as src/ioslaves/file/file.cpp?
Or how can it avoid duplication of code?


Thanks.
Comment 1 Nate Graham 2018-08-22 20:37:16 UTC 
Yes, please go ahead. You can submit a patch if you'd like! See https://community.kde.org/Infrastructure/Phabricator

If there are issues with your approach, that's what code review is for :)