Bug 372721 - on rtl langs, view problem on the settings of widgets
Summary: on rtl langs, view problem on the settings of widgets
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (show other bugs)
Version: 5.8.2
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-21 07:51 UTC by ttv200
Modified: 2016-11-22 14:03 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
the problem (40.63 KB, image/png)
2016-11-21 07:51 UTC, ttv200
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ttv200 2016-11-21 07:51:35 UTC
Created attachment 102358 [details]
the problem

The setting dialog is rtl bug the block with the setting is ltr
Because of that there is a extra padding
This problem exist in all the widgets settings

see attachment
Comment 1 ttv200 2016-11-21 12:47:42 UTC
David Edmundson, its not only on task manager
its on few widget setting (clock, system tray and is components and ,maybe more)
Comment 2 Marco Martin 2016-11-21 13:24:27 UTC
what is exactly the problem? should it be right-aligned?
Comment 3 Eike Hein 2016-11-21 17:44:44 UTC
The problem is that the individual controls are rtl, but the entire thing is on the left.
Comment 4 Marco Martin 2016-11-22 14:00:50 UTC
Git commit cf2d9d96581bd79b3a5b1c0a7674857d451734ac by Marco Martin.
Committed on 22/11/2016 at 14:00.
Pushed by mart into branch 'master'.

fix config dialogs in ltr mode

Summary:
anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled

Test Plan: opened all config dialogs both in ltr and ltr layouts

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3456

M  +1    -0    applets/analog-clock/contents/ui/configGeneral.qml
M  +1    -0    applets/calendar/package/contents/ui/configGeneral.qml
M  +1    -0    applets/devicenotifier/package/contents/ui/configGeneral.qml
M  +1    -0    applets/digital-clock/package/contents/ui/configAppearance.qml
M  +1    -0    applets/digital-clock/package/contents/ui/configCalendar.qml
M  +1    -0    applets/lock_logout/contents/ui/ConfigGeneral.qml
M  +1    -0    applets/notifications/package/contents/ui/configNotifications.qml
M  +1    -0    applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
M  +1    -0    applets/systemtray/package/contents/ui/ConfigGeneral.qml

http://commits.kde.org/plasma-workspace/cf2d9d96581bd79b3a5b1c0a7674857d451734ac
Comment 5 Marco Martin 2016-11-22 14:02:34 UTC
Git commit 7355b783c28a56715594697b2b90efc3810f1e41 by Marco Martin.
Committed on 22/11/2016 at 14:02.
Pushed by mart into branch 'Plasma/5.8'.

fix config dialogs in ltr mode

Summary:
anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled

Test Plan: opened all config dialogs both in ltr and ltr layouts

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3456

M  +1    -0    applets/analog-clock/contents/ui/configGeneral.qml
M  +1    -0    applets/calendar/package/contents/ui/configGeneral.qml
M  +1    -0    applets/devicenotifier/package/contents/ui/configGeneral.qml
M  +1    -0    applets/digital-clock/package/contents/ui/configAppearance.qml
M  +1    -0    applets/digital-clock/package/contents/ui/configCalendar.qml
M  +1    -0    applets/lock_logout/contents/ui/ConfigGeneral.qml
M  +1    -0    applets/notifications/package/contents/ui/configNotifications.qml
M  +1    -0    applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
M  +1    -0    applets/systemtray/package/contents/ui/ConfigGeneral.qml

http://commits.kde.org/plasma-workspace/7355b783c28a56715594697b2b90efc3810f1e41
Comment 6 Marco Martin 2016-11-22 14:03:22 UTC
Git commit e18109e3c7646dd7319a8eb55da6dc010eed515d by Marco Martin.
Committed on 22/11/2016 at 14:03.
Pushed by mart into branch 'Plasma/5.8'.

fix config dialogs in ltr mode

Summary:
anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled

Test Plan: opened all config dialogs both in ltr and ltr layouts

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3457

M  +1    -0    applets/kicker/package/contents/ui/ConfigGeneral.qml
M  +1    -0    applets/pager/package/contents/ui/configGeneral.qml
M  +1    -0    applets/taskmanager/package/contents/ui/ConfigGeneral.qml

http://commits.kde.org/plasma-desktop/e18109e3c7646dd7319a8eb55da6dc010eed515d