Bug 372699 - Window minimizes to the center of the screen if multiple windows are open in the same group.
Summary: Window minimizes to the center of the screen if multiple windows are open in ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Icons-only Task Manager (other bugs)
Version First Reported In: 5.8.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-20 13:10 UTC by fufuheo
Modified: 2016-11-25 15:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description fufuheo 2016-11-20 13:10:56 UTC
Example: If you have one dolphin window open and click the minimize button, the window "minimizes" to the icons only task manager as expected, but if you open another dolphin window, that window minimizes to the center of the screen.
Happens with all applications. Always reproducible for me.
Comment 1 Eike Hein 2016-11-25 13:40:08 UTC
Git commit 9314abc1c8420afe21150bdf906cfacd3fc681bd by Eike Hein.
Committed on 25/11/2016 at 13:39.
Pushed by hein into branch 'master'.

Expose rowCount as data role in TaskGroupingProxyModel.

Summary:
This adds a new data role "ChildCount" to AbstractTasksModel and
implements it in TaskGroupingProxyModel.

The purpose of this data role is as a means of signalling to a Qt
Quick delegate for a top-level row that a property of the item -
namely the number of children it has - has changed. Qt Quick's poor
support for tree models makes the existing way of signaling this
(rowsInserted) prohibitive to use.

The Task Manager applet needs this info because it's in charge of
telling the window manager about the screen coordinates of window
delegates (through support code in this library). When a window is
directly added to an existing group, there is no new delegate
created, nor does the existing delegate change position. An
increase of ChildCount will be used in this case to decide to
publish delegate geo for the new window.

Reviewers: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3482

M  +1    -0    libtaskmanager/abstracttasksmodel.h
M  +3    -10   libtaskmanager/taskgroupingproxymodel.cpp

https://commits.kde.org/plasma-workspace/9314abc1c8420afe21150bdf906cfacd3fc681bd
Comment 2 Eike Hein 2016-11-25 13:40:22 UTC
Git commit 47ae1a50e0bdf5359452ba74876aba6cd8d10fb1 by Eike Hein.
Committed on 24/11/2016 at 09:40.
Pushed by hein into branch 'master'.

Publish delegate geometry when ChildCount increases.

Summary:
Publishes delegate geometry for new windows directly added to an
existing task group.

Depends on D3482.

Reviewers: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3483

M  +10   -0    applets/taskmanager/package/contents/ui/Task.qml

https://commits.kde.org/plasma-desktop/47ae1a50e0bdf5359452ba74876aba6cd8d10fb1
Comment 3 Eike Hein 2016-11-25 15:30:29 UTC
Git commit 781bb3426978661112e9ac7fef3574ca7d73bae7 by Eike Hein.
Committed on 25/11/2016 at 15:30.
Pushed by hein into branch 'Plasma/5.8'.

Expose rowCount as data role in TaskGroupingProxyModel.

Summary:
This adds a new data role "ChildCount" to AbstractTasksModel and
implements it in TaskGroupingProxyModel.

The purpose of this data role is as a means of signalling to a Qt
Quick delegate for a top-level row that a property of the item -
namely the number of children it has - has changed. Qt Quick's poor
support for tree models makes the existing way of signaling this
(rowsInserted) prohibitive to use.

The Task Manager applet needs this info because it's in charge of
telling the window manager about the screen coordinates of window
delegates (through support code in this library). When a window is
directly added to an existing group, there is no new delegate
created, nor does the existing delegate change position. An
increase of ChildCount will be used in this case to decide to
publish delegate geo for the new window.

Reviewers: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3482

M  +1    -0    libtaskmanager/abstracttasksmodel.h
M  +3    -10   libtaskmanager/taskgroupingproxymodel.cpp

https://commits.kde.org/plasma-workspace/781bb3426978661112e9ac7fef3574ca7d73bae7
Comment 4 Eike Hein 2016-11-25 15:30:57 UTC
Git commit 04a758912b906c8d793361956dfb7193da86d982 by Eike Hein.
Committed on 25/11/2016 at 15:30.
Pushed by hein into branch 'Plasma/5.8'.

Publish delegate geometry when ChildCount increases.

Summary:
Publishes delegate geometry for new windows directly added to an
existing task group.

Depends on D3482.

Reviewers: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3483

M  +10   -0    applets/taskmanager/package/contents/ui/Task.qml

https://commits.kde.org/plasma-desktop/04a758912b906c8d793361956dfb7193da86d982