Bug 372685 - Oxygen theme style configuration icon out of place
Summary: Oxygen theme style configuration icon out of place
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-20 05:15 UTC by Marax Faraii
Modified: 2016-12-01 20:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Image showing the configuration icon (116.25 KB, image/png)
2016-11-20 05:15 UTC, Marax Faraii
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marax Faraii 2016-11-20 05:15:44 UTC
Created attachment 102325 [details]
Image showing the configuration icon

Apologies if this is the wrong place of filing this so please move it to appropriate location.

Now, to the bug. Best way to describe it is in the title as well as attached screenshot.

In the window decoration menu there are configuration icons above all the various styles, except for oxygen. 
If the window is maximized the icon is visible but when it's not the icon doesn't show at all.

Plasma version: 5.8.3
Kde Frameworks: 5.28.0
QT version: 5.6.2
Comment 1 Christoph Feck 2016-11-21 03:14:55 UTC
The configure icon is placed relative to the total decoration size (including shadows).
Comment 2 Martin Flöser 2016-11-21 07:59:27 UTC
@Andreas: can you have a look. That seems to be related to your QML change. If you don't know what it caused, please bug either Marco or David about it ;-)
Comment 3 Marax Faraii 2016-11-21 08:48:58 UTC
Don't know if this will be of any use but on my other laptop, running similar setup the icon also is out of place. However, not as much. Just slightly below widgetstyle.

The screen size is: 15in and 1366x768 

The one in the image is:
17in 1920x1080

Perhaps the misplacing of the icon is with scaling?
Comment 4 David Edmundson 2016-11-28 09:25:25 UTC
Git commit d0e0f6c88cdd032d3bdb9dc7b0c85902fb3d859a by David Edmundson.
Committed on 28/11/2016 at 09:24.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Align configure button consistently across delegates

Summary:
Currently the configure button is aligned to the win decoration in the
background. This is bound to 40 - the inactive decorations shadow.

This means the configure button ends up in different places across each
item,
looking a bit weird and potentially not even on top of the right
delegate.

This patch aligns the configure button relative to the overall delegate
so that it's in the same place on every item

Test Plan: Looked at KCM

Reviewers: #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3526

M  +3    -2    kcmkwin/kwindecoration/qml/Previews.qml

https://commits.kde.org/kwin/d0e0f6c88cdd032d3bdb9dc7b0c85902fb3d859a