Bug 372671 - solver doesn't build with ocaml 4.04
Summary: solver doesn't build with ocaml 4.04
Status: RESOLVED FIXED
Alias: None
Product: kalzium
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Kalzium Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-19 16:51 UTC by Antonio Rojas
Modified: 2017-08-03 16:14 UTC (History)
6 users (show)

See Also:
Latest Commit: https://commits.kde.org/kalzium/447d0ca4cc757f79ad02ca52ab5e086b78dfdfb1
Version Fixed In: 17.08
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2016-11-19 16:51:16 UTC 
The solver fails to build with ocaml 4.04:

[ 49%] Generating solver.o
cd /build/kalzium/src/build/src && /usr/bin/ocamlopt -output-obj -o /build/kalzium/src/build/src/solver.o /usr/lib/ocaml/facile/facile.cmxa /build/kalzium/src/build/src/chemset.cmx /build/kalzium/src/build/src/parser.cmx /build/kalzium/src/build/src/lexer.cmx /build/kalzium/src/build/src/datastruct.cmx /build/kalzium/src/build/src/chem.cmx /build/kalzium/src/build/src/calc.cmx
[ 50%] Generating modwrap.o
cd /build/kalzium/src/build/src && /usr/bin/ocamlopt -I /usr/lib/ocaml/facile -c /build/kalzium/src/kalzium-16.11.80/src/solver/modwrap.c -o /build/kalzium/src/build/src/modwrap.o
Options -c and -o are incompatible when compiling C files
make[2]: *** [src/CMakeFiles/kalzium.dir/build.make:105: src/modwrap.o] Error 2
make[2]: Leaving directory '/build/kalzium/src/build'
make[1]: *** [CMakeFiles/Makefile2:302: src/CMakeFiles/kalzium.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Comment 1 Viktor Yu. Kovalskii 2016-12-07 15:08:39 UTC 
(In reply to Antonio Rojas from comment #0)

I can confirm this issue.
kalzium from git fails to build with ocaml-4.04 with the same error.

I can build kalzium from git with ocaml-4.03.

Maybe changelog from ocaml-4.04 helps:

http://caml.inria.fr/pub/distrib/ocaml-4.04/notes/Changes
Comment 2 Viktor Yu. Kovalskii 2016-12-18 07:44:21 UTC 
(In reply to Viktor Yu. Kovalskiy from comment #1)
> (In reply to Antonio Rojas from comment #0)
> 
> I can confirm this issue.
> kalzium from git fails to build with ocaml-4.04 with the same error.
> 
> I can build kalzium from git with ocaml-4.03.
> 
> Maybe changelog from ocaml-4.04 helps:
> 
> http://caml.inria.fr/pub/distrib/ocaml-4.04/notes/Changes

Kalzium-16.12.0 fails to build with the same error.
Comment 3 Christoph Feck 2016-12-20 18:50:46 UTC 
This commit has all the details of the change: https://github.com/ocaml/ocaml/commit/da56cf6dfdc13c09905c2e07f1d4849c8346eec8
Comment 4 José Manuel Santamaría Lema 2017-07-17 04:17:47 UTC 
Hi,

I'm going to mark this as 'confirmed', because, indeed, it's also failing when building against ubuntu artful with -proposed enabled, which provides ocaml 4.04.

This means we won't be able to update kalzium for ubuntu artful, so it would be nice to get this fixed.

Regards.
Comment 5 José Manuel Santamaría Lema 2017-07-17 13:14:56 UTC 
Possible fix:
https://phabricator.kde.org/D6752
Comment 6 Christoph Feck 2017-08-03 16:14:05 UTC 
Git commit 447d0ca4cc757f79ad02ca52ab5e086b78dfdfb1 by Christoph Feck, on behalf of José Manuel Santamaría Lema.
Committed on 03/08/2017 at 16:10.
Pushed by cfeck into branch 'Applications/17.08'.

Fix build with ocaml 4.04
FIXED-IN: 17.08

Differential Revision: https://phabricator.kde.org/D6752

M  +1    -1    src/CMakeOCamlInstructions.cmake

https://commits.kde.org/kalzium/447d0ca4cc757f79ad02ca52ab5e086b78dfdfb1