Bug 372665 - OSD shows different sized icon depending on text
Summary: OSD shows different sized icon depending on text
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
: 400088 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-19 14:22 UTC by Martin Flöser
Modified: 2020-05-19 20:04 UTC (History)
6 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/af31ad46c025c0e53de1427527876366fcd869a6
Version Fixed In: 5.20.0
Sentry Crash Report:

Attachments
English Layout (1.72 MB, image/png)
2016-11-19 14:22 UTC, Martin Flöser 		Details
German layout (1.72 MB, image/png)
2016-11-19 14:22 UTC, Martin Flöser 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Flöser 2016-11-19 14:22:18 UTC 
Created attachment 102322 [details]
English Layout

Steps to reproduce:
1. Use two keyboard layouts (e.g. English (US) and German)
2. Switch between the layouts

Actual result:
icon changes size when switching the layouts

Expected result:

Icon stays the same

See the attached screenshots.
Comment 1 Martin Flöser 2016-11-19 14:22:38 UTC 
Created attachment 102323 [details]
German layout
Comment 2 Kai Uwe Broulik 2016-11-19 14:24:11 UTC 
I've seen a bug report about this before and I thought David even fixed it, but I can confirm. Also happens with text vs slider (e.g. muted vs non-muted audio)
Comment 3 David Edmundson 2016-11-20 13:33:25 UTC 
I thought I fixed the slider vs text ; my change wouldn't have had an impact on the different text though.
Comment 4 Alexander Mentyu 2017-11-26 14:55:31 UTC 
Can confirm in:

Distribution: KDE neon Developer Edition - Stable Branches
Plasma: 5.11.3
Frameworks: 5.41.0
Qt: 5.9.2
Kernel 4.10.0-38-generic
Type: 64-bit

Also i notices that keyboard lang change notification appears only in Wayland.
Comment 5 Alexander Mentyu 2018-10-22 08:34:11 UTC 
*** Bug 400088 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2020-04-15 01:13:22 UTC 
*** Bug 419551 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2020-05-19 20:04:03 UTC 
Git commit af31ad46c025c0e53de1427527876366fcd869a6 by Nate Graham, on behalf of Kai Uwe Broulik.
Committed on 19/05/2020 at 20:03.
Pushed by ngraham into branch 'master'.

Use more compact OSD

Summary:
A frequent complaint over the years is the size of the OSD. It was tried to alleviate that by having it start fading out slowly immediately but the way it was done wasn't ideal, didn't work on Wayland, and also causes flickering issues in recent Qt versions.
This changes the OSD to a bar-like design similar to the one used in Plasma 4.
Related: bug 344393
FIXED-IN: 5.20.0

Depends on D29263

Test Plan:
Various OSD messages
{F6773939}
It can grow, if necccessary, to accomodate translations, up to half the screen width.
With Air theme
{F6773940}
Full desktop screenshot for some context
{F6773941}

Reviewers: #plasma, #vdg, broulik, niccolove, ndavis

Reviewed By: #vdg, niccolove, ndavis

Subscribers: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20569

M  +20   -44   lookandfeel/contents/osd/OsdItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/af31ad46c025c0e53de1427527876366fcd869a6