Bug 372518 - Checksums should match if pasted text is uppercase
Summary: Checksums should match if pasted text is uppercase
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-16 00:56 UTC by sedrubal
Modified: 2016-11-17 17:27 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.29


Attachments
The uppercase checksum should match with the lowercase md5 checksum. (60.93 KB, image/png)
2016-11-16 00:56 UTC, sedrubal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sedrubal 2016-11-16 00:56:05 UTC
Created attachment 102251 [details]
The uppercase checksum should match with the lowercase md5 checksum.

Dolphin can check checksums (MD5, SHA1, SHA256) in the file properties dialog. You can calculate the checksums and then paste the expected checksum in a field. The field turns green, if it matches and red if it doesn't match. The calculated checksums are lowercase.

If you paste the correct uppercase checksum the checksum field turns red even if it matches.
Comment 1 Elvis Angelaccio 2016-11-16 12:32:13 UTC
Git commit d1c652aa68d0b891f7f9c4fe664e0d3cbdb133af by Elvis Angelaccio.
Committed on 16/11/2016 at 12:30.
Pushed by elvisangelaccio into branch 'master'.

Allow uppercase checksums matching in Checksums tab

While the checksum in cache is always guaranteed to be lowercase, the
one from the line edit may be uppercase. If we make it lowercase
*before* processing it, we can also simplify the regexes.

REVIEW: 129415
FIXED-IN: 5.29

M  +7    -4    src/widgets/kpropertiesdialog.cpp
M  +3    -0    src/widgets/kpropertiesdialog_p.h

http://commits.kde.org/kio/d1c652aa68d0b891f7f9c4fe664e0d3cbdb133af
Comment 2 sedrubal 2016-11-16 15:41:34 UTC
Thanks <3