Bug 372309 - Appearance -> Colors -> Edit Scheme (dialog breakup on vertical expand)
Summary: Appearance -> Colors -> Edit Scheme (dialog breakup on vertical expand)
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: 5.8.3
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Matthew Woehlke
URL:
Keywords: junior-jobs
: 376862 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-10 21:53 UTC by David Rankin
Modified: 2017-03-02 22:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.10
Sentry Crash Report:


Attachments
Snapshot showing 'Edit scheme' dialog breaking apart exposing blank dialog. (52.01 KB, image/png)
2016-11-10 21:53 UTC, David Rankin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Rankin 2016-11-10 21:53:20 UTC
Created attachment 102161 [details]
Snapshot showing 'Edit scheme' dialog breaking apart exposing blank dialog.

Version 5.8.3

When expanding the Appearance -> Colors -> Edit Scheme dialog vertically, the dialog does not properly expand the 'Color set:' portion to maximize editing the color scheme list of colors. Instead the 'Window text' widget and the 'Color set:' widgets separate and break apart wasting 1/3 to 1/2 of the 900px screen with completely wasted space.

When maximizing the dialog vertically, the 'Color set:' widget should be the only widget that expands maximizing the space available for editing the color-scheme instead of just expanding the blank window behind the widgets.

Screenshot included:
Comment 1 andydecleyre 2016-12-09 17:59:18 UTC
Quite inconvenient for looking at as many color as possible simultaneously. Just came here now to report this, thanks for doing it first.
Comment 2 Martin Koller 2017-01-29 14:47:07 UTC
Git commit 1d05792ad782ce4cd41e31c1ab6eef3026b5218b by Martin Koller.
Committed on 29/01/2017 at 14:44.
Pushed by mkoller into branch 'master'.

Fix some bugs (mem leak, layout, preview not showing colors)

1) memory leak when opening SchemeEditorDialog (is never deleted)
2) The color preview widget can be reduced in height to nearly zero,
   which makes no sense
3) The scheme editor does not reflect any color change
   in the preview widget
4) triple-redundant widgets in the scmeditorcolors.ui file
5) user unfriendly current tab when opening the SchemeEditorDialog
   (I want to change a color, so the color tab shall be active)
6) Unneeded and incorrect tab index enum (enum values were not
   corresponding to the index the tab was inserted)
7) The SchemeEditorDialog did not just only expand the color table when
   enlarging the dialogs height
Related: bug 372407
REVIEW: 129902

M  +1    -0    kcms/colors/colorscm.cpp
M  +0    -6    kcms/colors/colorsettings.ui
M  +18   -18   kcms/colors/preview.ui
M  +1    -0    kcms/colors/scmeditorcolors.cpp
M  +5    -141  kcms/colors/scmeditorcolors.ui
M  +6    -5    kcms/colors/scmeditordialog.cpp
M  +0    -7    kcms/colors/scmeditordialog.h
M  +0    -12   kcms/colors/scmeditordialog.ui

https://commits.kde.org/plasma-desktop/1d05792ad782ce4cd41e31c1ab6eef3026b5218b
Comment 3 andydecleyre 2017-02-21 19:37:35 UTC
This hasn't made it into a release yet, has it?
Comment 4 Christoph Feck 2017-03-02 22:43:41 UTC
*** Bug 376862 has been marked as a duplicate of this bug. ***