Bug 372207 - kwrite file open dialog, filenames overwrite icons (probably all apps)
Summary: kwrite file open dialog, filenames overwrite icons (probably all apps)
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 381060 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-08 09:25 UTC by David Rankin
Modified: 2017-09-19 11:42 UTC (History)
4 users (show)

See Also:
Latest Commit: https://commits.kde.org/kio/31361267d41977047e2523ae95718b20713d0d6d
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
File open dialog showing filename overwriting file icon in dialog. (99.83 KB, image/png)
2016-11-08 09:25 UTC, David Rankin 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Rankin 2016-11-08 09:25:16 UTC 
Created attachment 102118 [details]
File open dialog showing filename overwriting file icon in dialog.

When using File -> Open, filenames with the .dat, .rdf (probably any binary file) the filename is not shown correctly, instead it is shown "On Top Of" the file icon itself. This should not happen. A screenshot is attached. Look at, e.g.:

localstore.rdf
mailViews.dat

for examples of the problem.
Comment 1 Christoph Feck 2016-11-09 00:35:03 UTC 
It looks like Qt thinks these file types have no associated icon, and does not reserve any space for them. Then, something else thinks they should get a default icon anyway.
Comment 2 Christoph Feck 2017-06-10 10:15:12 UTC 
*** Bug 381060 has been marked as a duplicate of this bug. ***
Comment 3 Christoph Feck 2017-09-04 15:17:16 UTC 
https://phabricator.kde.org/D7318
Comment 4 Fabian Vogt 2017-09-19 11:42:07 UTC 
Git commit 31361267d41977047e2523ae95718b20713d0d6d by Fabian Vogt.
Committed on 19/09/2017 at 11:41.
Pushed by fvogt into branch 'master'.

KFileItemDelegate: Always reserve space for icons

Summary:
Even null icons are drawn so also reserve space for them to avoid overlapping.

Test Plan: http://imgur.com/a/fG2T0

Reviewers: #frameworks

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D7318

M  +1    -4    src/widgets/kfileitemdelegate.cpp

https://commits.kde.org/kio/31361267d41977047e2523ae95718b20713d0d6d