Bug 372135 - icon name for tray and notification
Summary: icon name for tray and notification
Status: RESOLVED WORKSFORME
Alias: None
Product: trojita
Classification: Unmaintained
Component: Desktop GUI (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Trojita default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-06 11:25 UTC by varlesh
Modified: 2022-11-26 05:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
plasma5 + trojita (82.08 KB, image/png)
2016-11-06 18:40 UTC, varlesh
Details
icon tray (227.55 KB, image/png)
2016-11-06 19:06 UTC, varlesh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description varlesh 2016-11-06 11:25:09 UTC
Please add another icon name for tray icon (use from icon theme). For example - trojita-panel.
For KDE and other DE use mostly monochrome icons for tray. Also will be good if you add notification with libnotify.
Comment 1 varlesh 2016-11-06 11:39:38 UTC
Or another way - add support integrate to plasmashell. For example kmail, cantata and others apps use tray icon plasma desktop theme.
Comment 2 Jan Kundrát 2016-11-06 12:28:05 UTC
Just FYI, the icon is being loaded through a theme-aware lookup already, so if -- for example -- the Breeze icon theme starts including an appropriate themed icon, it will be automatically used.

But I can see that it makes sense to use a slightly different icon for the tray. I won't have time for this "soon", so if you can make a change, please go for it. A correct place for changing the icon is MainWindow::handleTrayIconChange in src/Gui/Window.cpp; the icons are defined in src/icons.qrc.

Regarding a proper notification system, sure -- that will (eventually) come in future. Help is appreciated.
Comment 3 varlesh 2016-11-06 12:39:23 UTC
Sorry, but i'm not programmer. Need only another icon name for tray (this solution universal for all DE). I think it's easy doing :)

Desktop icon = trojita
Tray icon = trojita-panel

All tray icons on Plasma monochrome (it's Breeze default style)
Comment 4 Thomas Lübking 2016-11-06 17:56:13 UTC
QSystemTray icon should use SNI on plasma anyway (through QPA), but I'm not sure in how far you can override the try icon with the theme (which would be the one and only reasonable approach for it makes zero sense to provide a black systrayicon if you're using a black panel)
Comment 5 varlesh 2016-11-06 18:40:05 UTC
Created attachment 102074 [details]
plasma5 + trojita

If icon not hardcoded any designer or developer can create white and black icons on icon theme.
Now for tray use desktop icon - it's spoil style!
You really like this icon on tray?
Comment 6 Thomas Lübking 2016-11-06 18:48:57 UTC
You're missing the point: the palsmashell theme should be able to override the icon. The icon is not hardcoded since QSystemtrayIcon should really be using SNI, by what only the icon name is transferred and not a window of the application be embedded. The theme author /can/ override the icon.
Comment 7 varlesh 2016-11-06 19:06:56 UTC
Created attachment 102075 [details]
icon tray

Ok, i'm create new icon on plasmashell desktop theme (NOT icon theme) - but this not working!!!
See  attached file.
Note - this default Breeze Plasma desktop theme and icons apply for kopete, konversation and etc from plasma desktop theme. Trojita - it's part KDE software. Why icon not apply from plasma desktop theme?
Why for actions icons you use Breeze style, but for tray use your style?
You don't know this?:
https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Theming_Application_Icons_in_the_Systemtray
Comment 8 Thomas Lübking 2016-11-06 19:13:03 UTC
Personally, I'm out for the OPs manners.
Comment 9 varlesh 2016-11-06 19:18:16 UTC
Also on Breeze plasma desktop theme already available icons for mail applications.
It's mail.svgz, contained 2 icons - "mail-unread" and "mail-unread-new"
Comment 10 varlesh 2016-11-06 19:43:40 UTC
Sorry for my rudeness and perseverance ... I'm bad know English and i'm maybe not understand you correctly.
Comment 11 Justin Zobel 2022-10-27 02:48:51 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 12 Bug Janitor Service 2022-11-11 05:18:36 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 13 Bug Janitor Service 2022-11-26 05:16:17 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!