Bug 372112 - No second row for header
Summary: No second row for header
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.8.0
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-05 16:15 UTC by Christoph
Modified: 2016-12-12 10:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Uncomplete header of notification (107.63 KB, image/png)
2016-11-05 16:15 UTC, Christoph
Details
Website sends only header (219.89 KB, image/png)
2016-11-07 09:37 UTC, Christoph
Details
Website with correct header / body (102.21 KB, image/png)
2016-11-07 09:40 UTC, Christoph
Details
Nextcloud's notification (43.15 KB, image/png)
2016-11-19 12:08 UTC, Christoph
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph 2016-11-05 16:15:34 UTC
Created attachment 102053 [details]
Uncomplete header of notification

It doesn't appear a second row for the header of a notification when the message is too long for the widget size.

Steps to reproduce:
1.) Run "notify-send -t 0 testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttest123 test"
2.) You can't see the whole message. "123" of the string is lost.

Expected results:
Instead of "..." the whole information should appear

I know that a summary isn't often so long but some HTML5 notifications, forwarded through Firefox' Gnotifier addon, contain long headers instead of a short summary in the header and a long body... Would be great to read all information.

Thanks!
Comment 1 Christoph Feck 2016-11-06 23:05:52 UTC
I am a bit unsure if this really should be changed. The header is only a headline. The actual contents comes after the headline. If we allowed wrapping the headline to multiple lines, we might fill up the space and have no room to show the (important?) contents.

Could you please show a screen shot of an actual "Gnotifier" message? Maybe that addon needs to be changed to move the text to the content rows, instead of showing it at the headline.
Comment 2 Christoph 2016-11-07 09:37:27 UTC
Created attachment 102091 [details]
Website sends only header

It depends on the website. Some web sites send correct header/bodys, some web sites send only header.
Comment 3 Christoph 2016-11-07 09:40:21 UTC
Created attachment 102092 [details]
Website with correct header / body
Comment 4 Marco Martin 2016-11-07 15:01:52 UTC
the header should really be just some short title.
as a workaround of things sending incorrect content, it could be done that if only header text is present, to display it in the body block instead
Comment 5 Christoph 2016-11-07 15:14:00 UTC
What about a mouse hover that could show the whole text? Unfortunately I'm not able to code it...
Comment 6 Christoph 2016-11-19 12:08:20 UTC
Created attachment 102317 [details]
Nextcloud's notification
Comment 7 Kai Uwe Broulik 2016-11-19 13:30:30 UTC
I won't enable word wrapping for the summary, as this is "a single line overview of the notification", according to the spec. (The spec does say servers *should* word wrap if neccessary but I disagree, this contradicts the "single line" statement)

I like Marco's idea of putting the summary as body text if only a summary is given, and then perhaps use the application name as title instead.
Comment 8 Christoph 2016-11-19 14:45:44 UTC
Yes, I highly agree with the propositions made! Would be a good feature.
Comment 9 Marco Martin 2016-12-12 10:40:23 UTC
solved by commit
cbf06cf862c5779f2c16a6903e828c67d5c1a670