Bug 372037 - Right clicking background in desktop grid causes glitching
Summary: Right clicking background in desktop grid causes glitching
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-desktop-grid (show other bugs)
Version: 5.8.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL: https://phabricator.kde.org/D3253
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-03 20:17 UTC by pbs3141
Modified: 2016-11-04 10:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.8.4
Sentry Crash Report:
mgraesslin: ReviewRequest+


Attachments
Screenshot of glitching (1.34 MB, image/jpeg)
2016-11-03 20:17 UTC, pbs3141
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pbs3141 2016-11-03 20:17:59 UTC
Created attachment 102014 [details]
Screenshot of glitching

Steps to reproduce:
 • Activate the desktop grid.
 • Right-click on any part of a desktop not covered by a window.

What goes wrong:
 • For every desktop except the one that was right-clicked, the desktop background is presented like just another window.
 • Floating x-buttons randomly appear on some of the desktops.
 • See the attached screenshot.
 • Kwin becomes extremely laggy until the desktop grid is closed.
Comment 1 Martin Flöser 2016-11-04 08:32:45 UTC
Patch at https://phabricator.kde.org/D3253
Comment 2 Martin Flöser 2016-11-04 10:13:34 UTC
Git commit 3c6371390d698c8dd7a8c0704debba43d5d3b465 by Martin Gräßlin.
Committed on 04/11/2016 at 08:32.
Pushed by graesslin into branch 'Plasma/5.8'.

[desktopgrid] Don't manipulate virtual desktop of desktop window

Summary:
Desktop Grid has a feature that right or middle clicking a window toggles
the on all desktop state. If that is done for a desktop window, things
obviously start to fail.

KWin internally allows to change virtual desktop for all windows, even
for windows like the desktop or docks. Changing in KWin core is not a
solution.

Thus a special casing in desktop grid is added to disallow the selection
for desktop windows.
FIXED-IN: 5.8.4

Test Plan: Tried right clicking desktop window and other windows.

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3253

M  +3    -0    effects/desktopgrid/desktopgrid.cpp

http://commits.kde.org/kwin/3c6371390d698c8dd7a8c0704debba43d5d3b465