Bug 371987 - checkXML5 generates html files in workdir for valid docbooks
Summary: checkXML5 generates html files in workdir for valid docbooks
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kdoctools
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Documentation Editorial Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-02 18:17 UTC by Burkhard Lück
Modified: 2016-11-07 15:26 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.28.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2016-11-02 18:17:11 UTC
using checkXML5 on a valid docbooks generates all html pages in the workdir.

checkXML5 should execute 
"meinproc5 --check --stdout arguments[1] > /dev/null" using QProcess::execute()

or

meinproc5 should not generate any output called with "--check" for a valid docbook
Comment 1 Ralf Habacker 2016-11-02 18:43:19 UTC
I'm a confused. The original checkXML5 c++ implementation runs meinproc5 exactly with the same set of command line options as the former shell script. With bug 369415 --stdout has been removed on your request. Do you want to revert this fix ? Please explain.
Comment 2 Ralf Habacker 2016-11-02 18:47:11 UTC
(In reply to Burkhard Lueck from comment #0) 
> meinproc5 should not generate any output called with "--check" for a valid docbook
running meinproc5 --check from release 5.27.0 does not print any output.
Comment 3 Burkhard Lück 2016-11-02 19:22:51 UTC
(In reply to Ralf Habacker from comment #1)
> I'm a confused. The original checkXML5 c++ implementation runs meinproc5
> exactly with the same set of command line options as the former shell
> script.

That is wrong, the original checkXML5 c++ implementation used:

exit `${CMAKE_INSTALL_PREFIX}/bin/meinproc4 --check --stdout $@ > /dev/null`
Comment 4 Burkhard Lück 2016-11-02 19:29:47 UTC
(In reply to Ralf Habacker from comment #2)
> (In reply to Burkhard Lueck from comment #0) 
> > meinproc5 should not generate any output called with "--check" for a valid docbook
> running meinproc5 --check from release 5.27.0 does not print any output.

kdoctools checked out today build from sources does generate html files in workdir for valid docbooks:

$ ls *html
ls: cannot access '*html': No such file or directory
$ checkXML5 kdeutils/ark/doc/index.docbook 
$ ls *html
ark-create.html  ark-extract.html  ark-in_filemanager.html  ark-work-files.html  batchmode.html  credits.html  index.html  introduction.html  using-ark.html
$ rm *html
$ ls *html
ls: cannot access '*html': No such file or directory
$ meinproc5 --check kdeutils/ark/doc/index.docbook
$ ls *html
ark-create.html  ark-extract.html  ark-in_filemanager.html  ark-work-files.html  batchmode.html  credits.html  index.html  introduction.html  using-ark.html
$
Comment 5 Ralf Habacker 2016-11-02 19:41:08 UTC
(In reply to Burkhard Lueck from comment #4)
> kdoctools checked out today build from sources does generate html files in
> workdir for valid docbooks:
I see, thanks for pointing it out.
Comment 6 Ralf Habacker 2016-11-04 13:25:02 UTC
Git commit 29c0ecf99c50bb4bed62a4d90f45e5c9e3899d1c by Ralf Habacker.
Committed on 04/11/2016 at 13:23.
Pushed by habacker into branch 'master'.

Fix 'checkXML5 generates html files in workdir for valid docbooks'.
REVIEW:129314

M  +12   -2    src/checkXML5.cpp

http://commits.kde.org/kdoctools/29c0ecf99c50bb4bed62a4d90f45e5c9e3899d1c