Bug 371735 - vertically maximizing a window causes corrupted border decoration
Summary: vertically maximizing a window causes corrupted border decoration
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: 5.8.2
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL: https://phabricator.kde.org/D3186
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-27 08:55 UTC by S. Christian Collins
Modified: 2016-10-28 14:07 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/kwin/37067f538ec071e8ab9637052410953973b7c864
Version Fixed In: 5.8.3
mgraesslin: ReviewRequest+

Attachments
screenshot showing the bug (111.01 KB, image/png)
2016-10-27 08:55 UTC, S. Christian Collins 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description S. Christian Collins 2016-10-27 08:55:54 UTC 
Created attachment 101829 [details]
screenshot showing the bug

Steps to reproduce:
1. Open a program (in my case, KWin) and size the window fairly small.
2. Middle-click on the maximize button to maximize the window vertically.

Result: The lower portion of the side window borders disappear and appear transparent (see attached screenshot).

This happens on both of my PCs:
** System #1 **
OS: KDE Neon 5.8.2 64-bit (Plasma Desktop 5.8.2, KDE Frameworks 5.27.0, Qt 5.7.0)
Motherboard: ASRock X58 Extreme3 (Intel X58 chipset)
CPU: Intel Core i7 930 (2.8 GHz quad-core)
RAM: 12GB DDR3
Video: NVIDIA GeForce GTX 970 w/ 4GB RAM (PCI Express)
Linux Kernel: 4.4.0.45-generic
NVIDIA video driver: 361.42

** System #2 **
OS: KDE Neon 5.8.2 64-bit (Plasma Desktop 5.8.2, KDE Frameworks 5.27.0, Qt 5.7.0)
PC: HP Pavilion m6-1035dx
CPU/GPU: AMD A10-4600M APU with Radeon HD 7660G Graphics (using xorg radeon driver)
RAM: 6GB DDR3 800 MHz
Linux Kernel: 4.4.0.45-generic
Comment 1 Martin Flöser 2016-10-27 09:08:31 UTC 
please provide output of:
qdbus org.kde.KWin /KWin supportInformation
Comment 2 Martin Flöser 2016-10-27 09:12:21 UTC 
No need to provide the output, I can reproduce
Comment 3 S. Christian Collins 2016-10-27 17:55:45 UTC 
Awesome. I'm a huge fan of your work, Martin. Thanks for all you do to make kwin the best window manager out there :)
Comment 4 Martin Flöser 2016-10-28 09:49:20 UTC 
Possible patch at https://phabricator.kde.org/D3186
Comment 5 Martin Flöser 2016-10-28 14:07:20 UTC 
Git commit 37067f538ec071e8ab9637052410953973b7c864 by Martin Gräßlin.
Committed on 28/10/2016 at 14:06.
Pushed by graesslin into branch 'Plasma/5.8'.

Ensure the complete decoration texture gets repainted on recreation

Summary:
When the decoration size changes the textures get recreated and need to
be properly filled. So far KWin used the scheduled repaint geometry in
this situation. If the decoration didn't schedule the complete geometry
for repain there will be an empty area in the decoration texture.

This change ensures that the complete texture gets repainted when they
are recreated. Thus the decoration rendering is more fault tolerant
towards potential bugs in the decoration. With no-compositing and XRender
compositing this problem was not reproducable and already fault tolerant,
so OpenGL just catches up with the other modes.
FIXED-IN: 5.8.3

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3186

M  +3    -2    scene_opengl.cpp

http://commits.kde.org/kwin/37067f538ec071e8ab9637052410953973b7c864