Bug 371667 - Disabling Widget Animations makes Sidepanel moving impossible
Summary: Disabling Widget Animations makes Sidepanel moving impossible
Status: RESOLVED UPSTREAM
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: 5.8.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-25 14:28 UTC by Leszek Lesner
Modified: 2016-10-26 09:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leszek Lesner 2016-10-25 14:28:25 UTC
Disabling the animations for the Breeze Widget style in systemsettings makes moving panels in dolphin, marble impossible. 
Kdenlive even crashes when moving panels. 

Reproducible: Always

Steps to Reproduce:
1. Disable animation for breeze widget in systemsettings
2. Open Dolphin and unlock sidepanels if locked
3. Try to move the panels

Actual Results:  
Panels snap back to their initial position

Expected Results:  
Panels should snap to new position

Tested on Maui and Netrunner Core aswell as KDE Neon 5.8.2
Comment 1 Leszek Lesner 2016-10-25 14:33:25 UTC
I can also confirm this issue with Oxygen with disabled animations.
Comment 2 Hugo Pereira Da Costa 2016-10-25 14:42:28 UTC
Hi,
Thanks for reporting. However I cannot reproduce 
I suspect a bug in Qt, in fact. (which I do not have in my version).
The only thing disabling animations does to panels in breeze and oxygen is change the returned value of "SH_Widget_Animate"

if you have access to breeze sources, can you apply the following patch and see if code still crashes ?

diff --git a/kstyle/breezestyle.cpp b/kstyle/breezestyle.cpp
index 8a02d75..fa98a7b 100644
--- a/kstyle/breezestyle.cpp
+++ b/kstyle/breezestyle.cpp
@@ -646,7 +646,8 @@ namespace Breeze
             case SH_Menu_SloppySubMenus: return true;
 
             #if QT_VERSION >= 0x050000
-            case SH_Widget_Animate: return StyleConfigData::animationsEnabled();
+            // case SH_Widget_Animate: return StyleConfigData::animationsEnabled();
+            case SH_Widget_Animate: return true;
             case SH_Menu_SupportsSections: return true;
             #endif
Comment 3 Hugo Pereira Da Costa 2016-10-25 14:42:55 UTC
... or rather: not crashes, but: if you can again move panels?
Comment 4 Leszek Lesner 2016-10-25 15:16:51 UTC
Yes this fixes the issue. 
If it is a bug in Qt then the version might be important 5.7.0 is what all 3 distros use.
Comment 5 Hugo Pereira Da Costa 2016-10-25 15:25:29 UTC
Thanks for testing. So it is an upstream bug indeed (the only thing the patch does is change the value of a flag which is used internally by Qt and by Qt only. 
The version of Qt I have is 5.7.0 (and I do not have the bug). what is yours ?
Comment 6 Leszek Lesner 2016-10-25 15:28:03 UTC
It is also 5.7.0 coming from the Neon packages.
Comment 7 Hugo Pereira Da Costa 2016-10-25 15:32:13 UTC
ok. Not sure what to do about it then ... at least report the bug upstream (Qt) something like: "setting SH_Widget_Animate to false makes Sidepanel moving impossible". Will you do that ? Here at the breeze/oxygen level, the only thing I can do is apply the patch (and force animation of sidepanels all the time disregarding the actual option), but that would be a regression (triggered by upstream ...)
Wdyt ?
Comment 8 Leszek Lesner 2016-10-25 15:43:12 UTC
Reported to Qt here: https://bugreports.qt.io/browse/QTBUG-56736
Comment 9 Hugo Pereira Da Costa 2016-10-25 15:43:55 UTC
Thanks ! 
I'll leave this bug open in the meanwhile, waiting for further developments.
Comment 10 Christoph Feck 2016-10-26 01:07:56 UTC
Cannot reproduce with Qt 5.7.1 from openSUSE's Tumbleweed repositories, so it might already be fixed in Qt. I only tested Dolphin and kdenlive with Breeze animations disabled.
Comment 11 Christoph Feck 2016-10-26 01:11:41 UTC
Yes, see QTBUG-54185. I suggest to add this information to the Qt bug you reported.
Comment 12 Marco Martin 2016-10-26 09:13:37 UTC
for me also doesn't happen anymore on dolphin built against qt 5.7 branch, so post 5.7.0