I don't remember if it always was this way with KDE5 version of Krusader but for the last half a year it doesn't want to show icons or does it completely wrong on the rare occasions then it does. See the screenshot showing Krusader's blunder with today's release version 2.5.0 while dolphin does it correctly. KDE4's krusader is also working correctly. In console it only writes stuff like: QPainter::begin: Paint device returned engine == 0, type: 3 QPainter::setCompositionMode: Painter not active QPainter::setCompositionMode: Painter not active QPainter::setOpacity: Painter not active It also ignores p7zip service menus from /usr/share/kservices5/ServiceMenus/p7zip_*.desktop while dolphin shows them correctly. I think this is the recent regression. Reproducible: Always Steps to Reproduce: 1. Open Krusader Actual Results: Can't even distinguish directories from files ! Expected Results: Proper icons.
Created attachment 101712 [details] Screenshot_20161023_131020.png Most icons are completely missing, for some reason there are icons for images but they are completely wrong ones. ServiceMenus are broken.
Created attachment 101713 [details] krusader5_build.log Build log.
quick idea: what icon themes do you have installed and what is the default one? What is your DE, LXDE? It looks like you're missing some icons. On the other hand if Dolphin displays them correctly Krusader must do something different to determine the icons.
(In reply to Alex Bikadorov from comment #3) > quick idea: what icon themes do you have installed and what is the default > one? What is your DE, LXDE? It looks like you're missing some icons. > > On the other hand if Dolphin displays them correctly Krusader must do > something different to determine the icons. LXQt. I'm missing nothing. I even have same icon theme set in all relevant configs. Everything on my system is using them correctly: Qt4/Qt5/gtk2/gtk3/whatever. > rpm -qa | grep -i \\-icon | sort -u adwaita-icon-theme-3.22.0-1.2.noarch breeze5-icons-5.26.0-1.1.noarch dmz-icon-theme-cursors-11.2.0-17.2.noarch fusion-icon-0.2.2-2.2.noarch gnome-colors-icon-theme-5.5.1-18.2.noarch gnome-icon-theme-3.12.0-4.1.noarch gnome-icon-theme-extras-3.12.0-3.2.noarch gnome-icon-theme-symbolic-3.12.0-3.2.noarch hicolor-icon-theme-0.15-3.1.noarch hicolor-icon-theme-branding-openSUSE-42.1-1.2.noarch libreoffice-icon-theme-breeze-5.2.2.2-1.4.noarch libreoffice-icon-theme-galaxy-5.2.2.2-1.4.noarch libreoffice-icon-theme-hicontrast-5.2.2.2-1.4.noarch libreoffice-icon-theme-oxygen-5.2.2.2-1.4.noarch libreoffice-icon-theme-sifr-5.2.2.2-1.4.noarch oxy_base-icon-theme-1.0-11.1.noarch oxy_elegant-icon-theme-1.0-11.1.noarch oxygen5-icon-theme-5.26.0-1.1.noarch oxygen-ionized-icon-theme-v1-4.6.2-40.1.noarch plataro-icon-theme-20160410-2.1.noarch sonar-icon-theme-11.3.1-28.2.noarch tango-icon-theme-0.8.90-27.2.noarch wm-icons-0.4.0-17.3.noarch I use custom theme from ~/.icons that itself is empty but has > Inherits=OxyElegantGreen,gnome-wise,oxygen-ionized_v1,Plataro,Sonar,Tango,OxyElegantBase,gnome-colors-common,oxygen,gnome,hicolor Then other themes have their Inherits redefined to consist only from the next entry from that list, so the order would be always preserved and I'll be spared from monochrome hipster crap showing anywhere. BUT it has nothing to do with Krusader because if I just set it to vanilla breeze, only the icons that are already shown change, panels are still empty with weird icons for images and nothing else. It also suspicious how slow KDE5 Krusader is starting up: > 10s. With strace it generates megabytes of text in seconds and can't even render its interface in a minute.
Created attachment 101715 [details] krusader.strace.zip strace of 20 startup second of krusader under LXQt with breeze icon theme. First it does something stupid with icons and then starts to indefinitively pillage /sys filesystem.
Created attachment 101731 [details] Install missing icons to /usr/share/icons Some panel icons are also missing for me (compare files, mount manager, etc). I discovered that they are installed to /usr/shar /krusader/icons instead of /usr/share/icons. When I'd changed this path in CMakeLists.txt, they began to be displayed again. So here is my patch.
(In reply to WiseLord from comment #6) > Some panel icons are also missing for me (compare files, mount manager, > etc). I had in mind not panel, but toolbar icons.
(In reply to WiseLord from comment #7) > (In reply to WiseLord from comment #6) > > Some panel icons are also missing for me (compare files, mount manager, > > etc). > > I had in mind not panel, but toolbar icons. Yeah, unfortunately it's not changing situation with panels :(
Created attachment 101740 [details] breeze_icons thanks for the patch, looks good! Which icons are missing in the panel, only for the navigation bar? Attached is a screenshot from my system. Missing icons in the navigation bar is really strange cause Krusader and Dolphin are using exactly the same widget from KF5, KUrlNavigationBar.
(In reply to Alex Bikadorov from comment #9) > Created attachment 101740 [details] > breeze_icons > > thanks for the patch, looks good! > > Which icons are missing in the panel, only for the navigation bar? Attached > is a screenshot from my system. 0_o Which ? All of them ! All files and folders have no icons ! It's just doesn't render them next to filenames. Except for weird and wrong icons on picture files (png and such). _Sometimes_ there are folder icons in navigation bar, _sometimes_ they are correct green ones but most of the times it's emptiness or some artifact-looking things there too. But there are no icons for anything and I can't distinguish files from folders. > Missing icons in the navigation bar is really strange cause Krusader and > Dolphin are using exactly the same widget from KF5, KUrlNavigationBar. It seems not exactly the same way because only krusader does that. I'm not 100% sure but I think older KF5 git-builds didn't have that issue. But, please, don't make me do git-bisect...
Created attachment 101743 [details] Window - Krusader - 2016-10-24_18:10:38.png This is how KDE4 krusader looks like with proper icons right now.
Created attachment 101744 [details] Window - Krusader - 2016-10-24_18:32:05.png Same things as previously but with current, KDE5 version of krusader. It's unusable in this state.
Sorry, but its hard to debug as everything is working fine for me. Can you test this in a KDE environment or with another pre-build package of 2.5.0? Anything that can pinpoint the actual problem is helpful. Also, can you rule out that something went wrong during building?
(In reply to Alex Bikadorov from comment #13) > Sorry, but its hard to debug as everything is working fine for me. Can you > test this in a KDE environment or with another pre-build package of 2.5.0? > Anything that can pinpoint the actual problem is helpful. If devs always could reproduce bugs just by launching their stuff, there wouldn't be any. I will not risk launching Plasma because the last time I did, it wrote a bunch of useless KDE configs and somehow broke startup of LXQt session altogether. Official openSUSE builds present the same problem. I have KDE_FULL_SESSION=false KDE_SESSION_VERSION=4 exported on LXQt session startup but launching krusader with any other values changes nothing. By the way, some KDE apps think that if KDE_FULL_SESSION exist with any non-empty value then it's equal to "true". That's dumb. > Also, can you rule out that something went wrong during building? I've put out full build and strace so *you* could answer that question to me. But if it would, OBS surely would fail the build. So, how about looking at which icons and in which order it tries to access in that krusader.strace.zip or comparing krusader's icon-loading code to dolphin ?
Created attachment 101818 [details] krusader5_default.strace.xz krusader5 uninterrupted strace from launch to exit with default config. It seems that it actually finds all "Inherited" themes from the icon theme but doesn't try to either load the actual icons from them or to render those icons but is really keen on loading those icons all directly from the main theme or "hicolor" (which supposed to be the last resort). Even when it finds one for directories in '/usr/share/icons/OxyElegantGreen/*/places/folder.png', it doesn't render it in panels. It also searches directly in user home like 3 times in a row or something.
> *you* Being helpful helps a lot. Somebody has developed a lot for Krusader, and has also tried to be helpful. > I will not risk launching Plasma A virtual machine can be used to test. > uninterrupted strace from launch Thank you for adding information.
I probably managed to kind of replicate the behaviour. I've installed clean Arch Linux on VirtualBox and then I've installed: lxqt 0.11 dolphin 16.08.2 kate 16.08.2 krusader 2.5.0 breeze 5.8.2 Both dolphin and krusader had absolutely no icons when started up. But after changing both Widget style and Icon theme in LXQt Appearance settings to Breeze, icons in Krusader and Dolphin was properly rendered. I've noticed that most icons was not rendered when Widget style is set to "Fusion". Can you try out some other widget styles?
Don't know if this is the same bug, but in KDE Neon 5.8.2, the update of Krusader to 2.5.0 causes loss of toolbar icons when opened in root mode. Only text is available, even though right-clicking on the toolbar shows "Icons Only" selected. Icons are present if not opened in root mode.
@Martin Thanks for debugging this! Can you find a setting where toolbar icons are shown and panel icons are missing? @Sergey > So, how about looking at which icons and in which order it tries to access in that krusader.strace.zip or comparing krusader's icon-loading code to dolphin ? This is what I already did. I looked at your build log and noticed that you used a build script and not a plain "cmake && make" to build. I searched in the strace and found that the icons are actually loaded but nevertheless (sometimes) not shown. I checked the code and it is the same like Dolphin (again: both are using the same predefined gui widgets, not modified). This leads me to the assumption that it is a lot more likely that something with your system is wrong and not with our code, wouldn't you agree? Until more reports are incoming that can pinpoint the reason, I assume it has something do do with LXQt and/or the icon settings. @Graham Which icon theme is set for root? If its not Breeze then the internal applications icons are not picked because the path was wrong. But this is not the same bug.
> Can you find a setting where toolbar icons are shown and panel icons are missing? Actually I cannot find such settings. Also the previously mentioned Fusion widget theme isn't causing problems anymore. So after fiddling with icon themes I suggest these steps when testing different icon themes: 1) Swith to different icon theme in LXQt Appearance settings 2) close Krusader 3) rm .cahce/icon-cache.kcache 4) start Krusader
Sorry about the typos - it should have been: rm .cache/icon-cache.kcache
ok, i tried LXQt now, too. And: At first no icons at all, in Dolphin and Krusader and even most icons were missing in LXQt configuration center. But setting > QT_QPA_PLATFORM_THEME=kde did the trick and all icons were fine again in Dolphin and Krusader. Still, I can't reproduce the actual problem the OP has.
> @Graham > Which icon theme is set for root? If its not Breeze then the internal > applications icons are not picked because the path was wrong. But this is > not the same bug. I have restored Neon from my last backup and pinned Krusader to the KDE 4 version.
(In reply to Graham from comment #18) > Don't know if this is the same bug, but in KDE Neon 5.8.2, the update of > Krusader to 2.5.0 causes loss of toolbar icons when opened in root mode. > > Only text is available, even though right-clicking on the toolbar shows > "Icons Only" selected. > > Icons are present if not opened in root mode. Can you check if it's the same problem as https://bugs.kde.org/show_bug.cgi?id=353263 and if it's so, does the method of https://bugs.kde.org/show_bug.cgi?id=353263#c12 work?
> Can you check if it's the same problem as > https://bugs.kde.org/show_bug.cgi?id=353263 > and if it's so, does the method of > https://bugs.kde.org/show_bug.cgi?id=353263#c12 > work? If I use the following command either in a terminal or as the exec command in the menu for Krusader it works in root mode, with icons present: kdesudo -c "KDE_SESSION_VERSION=5 KDE_FULL_SESSION=true dbus-launch krusader" However, I have had no luck trying to use the file: /etc/sudoers.d/workaround_kde5 The system doesn't seem to see it or do what it says. Although I have no idea what I'm doing, just monkey-see-monkey-do. This sort of problem was why I moved to Krusader, because Dolphin didn't work in root mode in KDE 5.
(In reply to Toni Asensi Esteve from comment #16) > > *you* > > Being helpful helps a lot. Somebody has developed a lot for Krusader, and > has also tried to be helpful. > Yeah, and it would be great to get some feedback on the info that I provided or a concrete request for data that may be needed instead of pretending that there is none and dismissing everything with remarks like "*anything* that can pinpoint the *actual problem* is helpful" and "being helpful helps a lot". Well, be helpful and propose something useful. If I knew how to fix it myself I would, so what kind of guess-work you want *me* to do if you're the ones who made it ? > > I will not risk launching Plasma > > A virtual machine can be used to test. And how exactly I supposed to replicate entirety of my setup in there ? Copying entirety of the system and user configs just for avoiding one package messing with my configs and all for a longshot just because you don't know what secret KDE variables the app that is supposed to be DE-independent (which is the whole point of KDE5's advertised modularity) may use ? Anyway, I risked running Plasma5 again and the result is even worse ! In Plasma everything lacks icons as if it actively ignores the contents of ~/.icons. But setting the icon theme in ~/.config/kdeglobals from custom one to simple "breeze" doesn't help much: dolphin gets breeze monochrome stuff but krusader presents the same issue with panels. With the custom theme under Plasma krusader starts lacking most other icons. > > uninterrupted strace from launch > > Thank you for adding information. Thanks for noticing from the second time. (In reply to WiseLord from comment #6) > Created attachment 101731 [details] > Install missing icons to /usr/share/icons > > Some panel icons are also missing for me (compare files, mount manager, > etc). I discovered that they are installed to /usr/shar /krusader/icons > instead of /usr/share/icons. When I'd changed this path in CMakeLists.txt, > they began to be displayed again. > So here is my patch. By the way, I just noticed that it seems to be a revert of the revert of previous krusader screw-up: https://github.com/KDE/krusader/commit/4b69dda12a15c38f5fc8ccfa4037839f6c5ac3a3 I've built an old revision of https://github.com/KDE/krusader/commit/d1cc62447cd159692f25208c757fc1bd4c74c741 which I though didn't have the issue back in 2015 but now it also did. So maybe it's a regression in KF5-5.8.2/Qt5-5.7.0 or it was always the reason I only used latest KDE4 release (which I highly doubt). Or it really hates some obscure but persistent option in some forgotten config. Moreover, after * changing icon themes in ~/.config/kdeglobals * removing .cache/icon-cache.kcache * recreating cache for customized themes in ~/.icons or using vanilla breeze and oxygen * QT_QPA_PLATFORM_THEME (kde/lxqt) * QT_STYLE_OVERRIDE (breeze/oxygen/gtk2) * KDE_FULL_SESSION (''/false/true) * KDE_SESSION_VERSION (4/5) * using dbus-launch * launching in weston with QT_QPA_PLATFORM=wayland-egl nothing in panels has changed >_< Ah, if only dolphin would have profile support... it already has "split view", built-in konsole, service menus, tabs, verbose view and previews, so when customized it looks almost like krusader. (In reply to Alex Bikadorov from comment #19) > > This is what I already did. I looked at your build log and noticed that you > used a build script and not a plain "cmake && make" to build. Does it make a difference ? "The build script" is Open Build Service's remote builder/packager. If I wanted to do this stuff on my system I would use Gentoo... but then again, without building manually. > I searched in > the strace and found that the icons are actually loaded but nevertheless > (sometimes) not shown. I checked the code and it is the same like Dolphin > (again: both are using the same predefined gui widgets, not modified). The icons on panels behave differently in comparison to all other elements, like toolbar. Are you sure their code is the same to dolphin ? What about "QPainter" messages ? It's the only other thing that is consistently present too. > This leads me to the assumption that it is a lot more likely that something > with your system is wrong and not with our code, wouldn't you agree? > Until more reports are incoming that can pinpoint the reason, I assume it > has something do do with LXQt and/or the icon settings. > Or that your code is well-tested only on your systems while people with similar glitches just don't bother complaining. After I managed to get kernel developers to fix the >2 year old hid_sony glitch that made usage of Sony DualShock 3 (one of the most popular gamepads in the world) impractical as well as the >6 months regression that made one of popular AMD GPU chips completely unusable (oh, the horrors of git-bisect !) on all Linux distributions without a single public complaint from anyone on both of them, I'm wouldn't rush with conclusions about code cleanliness.
Created attachment 101856 [details] Screen - 2016-10-28_15:17:45.jpg krusader5 and dolphin under Plasma5 with the same configs as previous screenshots. all dolphin and krusader's toolbar icons are messed up, in fact, all icons in all KDE apps are messed up as in krusader's panel, unlike how KDE apps look under LXQt. Changing icons to "breeze" in kdeglobals helps dolphin and krusader's toolbar but not krusader's panels.
> Well, be helpful and propose something useful. > If I knew how to fix it myself I would, so what kind of guess-work you want *me* to do if you're the ones who made it ? Just to make this clear: We are doing this in our free time for free. Demanding to get immediate help and expecting that stuff is fixed right away is insolent. Point. > And how exactly I supposed to replicate entirety of my setup in there ? Copying entirety of the system and user configs just for avoiding one package messing with my configs and all for a longshot just because you don't know what secret KDE variables the app that is supposed to be DE-independent (which is the whole point of KDE5's advertised modularity) may use ? That's another point: We are trying to be environment independent but we cannot test every possible setup. We also tried to reproduce your problem and failed. Now its best if you could find out what the actual reason for causing this is. Because its happening on *your* system and not for anybody else. Think about it: you are currently the only who is effected - with *your* specific setup. > I've built an old revision of https://github.com/KDE/krusader/commit/d1cc62447cd159692f25208c757fc1bd4c74c741 which I though didn't have the issue back in 2015 but now it also did. So maybe it's a regression in KF5-5.8.2/Qt5-5.7.0 or it was always the reason I only used latest KDE4 release (which I highly doubt). Or it really hates some obscure but persistent option in some forgotten config. Another reason why I think somethings with your setup is wrong (or maybe not *wrong* but causing it). Can you test it with another (clean) user account? > The icons on panels behave differently in comparison to all other elements, like toolbar. > Are you sure their code is the same to dolphin ? The URL navigation bar widget is the same. If the icon is missing here in Krusader but not Dolphin its not a code issue. > What about "QPainter" messages ? It's the only other thing that is consistently present too. This is most likely a symptom not the cause: http://stackoverflow.com/questions/4341707/qpainter-not-active > Or that your code is well-tested only on your systems while people with similar glitches just don't bother complaining. Again: until now you are the only one.
(In reply to Graham from comment #25) Hi! > However, I have had no luck trying to use the file: > /etc/sudoers.d/workaround_kde5 If it can be helpful this is what I executed using Kubuntu 16.04: echo 'Defaults env_keep += "KDE_SESSION_VERSION KDE_FULL_SESSION"' | sudo tee -a /etc/sudoers.d/workaround_plasma5 > /dev/null Greetings: Toni
Any news here? How a about behaviour with a clean, new user? Does the discussion for bug 372966 help?
(In reply to Alex Bikadorov from comment #30) > Any news here? How a about behaviour with a clean, new user? > > Does the discussion for bug 372966 help? Nothing that was Google'able changed anything in any significant way until I stumbled upon this article: http://divideoverflow.com/2017/05/Configuring_Krusader_to_use_different_icons_template/ Doing this forced krusader to load icons in panels: rm -v ~/.cache/icon-cache.kcache ln -vs /usr/share/icons/breeze-dark/breeze-icons-dark.rcc ~/.local/share/krusader/icontheme.rcc Ugly-ugly icons that are barely discernable with my not-too-dark theme. There is no difference with "breeze-icons.rcc" and those are only *.rcc files on my system. Fiddling with DE's icon theme, QT_QPA_PLATFORMTHEME, KDE_SESSION_VERSION and such may change icons in menus but they are not the problem. The problem is completely missing or incorrect filetype icons in panels.
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
KDE's bug-tracker needs new bug-status, "READ THE INFO !" or something. Anyway, recently I launched freshest build of krusader and the issue seems to be no longer present in it, so I presume that it was quietly fixed.