Bug 371493 - Background.qml in the SDDM theme imports QtGraphicalEffects although not used
Summary: Background.qml in the SDDM theme imports QtGraphicalEffects although not used
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Theme packages (show other bugs)
Version: 5.8.2
Platform: openSUSE Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL: https://www.reddit.com/r/openSUSE/com...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-22 19:42 UTC by Fabian Vogt
Modified: 2016-10-23 11:24 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/plasma-workspace/b61c232722aa80567590ee6dfee655e93e95f7ff
Version Fixed In: 5.8.3

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2016-10-22 19:42:37 UTC 
The "import QtGraphicalEffects 1.0" in sddm-theme/Background.qml can be removed.
By doing this the whole theme does not require the module to be installed.

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-10-22 19:48:18 UTC 
Doesn't the user delegate require it anyway? So even when removing it there (which should be done) I would still require said module and so do other parts of Plasma.
Comment 2 Fabian Vogt 2016-10-22 19:50:28 UTC 
(In reply to Kai Uwe Broulik from comment #1)
> Doesn't the user delegate require it anyway? So even when removing it there
> (which should be done) I would still require said module and so do other
> parts of Plasma.

It doesn't import QtGraphicalEffects, but it uses "ShaderEffect", which is to my surprise in QtQuick itself
Comment 3 Kai Uwe Broulik 2016-10-22 19:51:40 UTC 
OK, cool, thanks for the investigation, I'll have a look.
Comment 4 Kai Uwe Broulik 2016-10-23 11:24:40 UTC 
Git commit b61c232722aa80567590ee6dfee655e93e95f7ff by Kai Uwe Broulik.
Committed on 23/10/2016 at 11:24.
Pushed by broulik into branch 'Plasma/5.8'.

Remove unused import QtGraphicalEffects
FIXED-IN: 5.8.3

M  +0    -2    sddm-theme/Background.qml

http://commits.kde.org/plasma-workspace/b61c232722aa80567590ee6dfee655e93e95f7ff