Bug 371411 - Unify fstat64/fstatat64 wrappers
Summary: Unify fstat64/fstatat64 wrappers
Status: RESOLVED NOT A BUG
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-21 13:46 UTC by Marcin Juszkiewicz
Modified: 2021-10-04 09:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
patch (6.87 KB, patch)
2016-10-21 13:47 UTC, Marcin Juszkiewicz 		Details
move all *stat*64 to generic (11.76 KB, patch)
2016-10-21 13:56 UTC, Marcin Juszkiewicz 		Details
Handle (int flags) argument of fstatat64 on arm and ppc32 (1.68 KB, patch)
2016-10-21 14:37 UTC, Marcin Juszkiewicz 		Details
Show Obsolete (2) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Juszkiewicz 2016-10-21 13:46:49 UTC 
arm/mips32/ppc32/x86 have similar wrappers for those two syscalls.

arm/mips32 ones do not handled 4th arguments (int flags) of syscall.

Not tested.

Reproducible: Always
Comment 1 Marcin Juszkiewicz 2016-10-21 13:47:26 UTC 
Created attachment 101680 [details]
patch
Comment 2 Marcin Juszkiewicz 2016-10-21 13:56:08 UTC 
Created attachment 101681 [details]
move all *stat*64 to generic

this patch adds stat64 and lstat64
Comment 3 Marcin Juszkiewicz 2016-10-21 14:26:43 UTC 
should check first with build. stat structure differ per arch ;(
Comment 4 Marcin Juszkiewicz 2016-10-21 14:37:57 UTC 
Created attachment 101683 [details]
Handle (int flags) argument of fstatat64 on arm and ppc32

x86 and mips32 have wrappers which support all 4 arguments. So let arm and ppc32 join them.
Comment 5 Ivo Raisr 2017-05-05 15:35:44 UTC 
Marcin, please double check with the actual arm and ppc32 kernel and glibc that these syscalls really take the 4th argument (flags).
Perhaps they use oabi-compat?
Comment 6 Marcin Juszkiewicz 2021-10-04 09:04:57 UTC 
I forgot how I wanted to rewrite it.