Bug 371227 - Clean AArch64 syscall table
Summary: Clean AArch64 syscall table
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-19 15:42 UTC by Marcin Juszkiewicz
Modified: 2017-05-05 16:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
patch which adds all entries (24.94 KB, patch)
2016-10-19 15:52 UTC, Marcin Juszkiewicz 		Details
patch which reformats table (37.78 KB, patch)
2016-10-19 15:53 UTC, Marcin Juszkiewicz 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Juszkiewicz 2016-10-19 15:42:50 UTC 
AArch64 (arm64) syscall table has some entries omitted and there is a commented list of some not handled ones.

This patchset drops commented part, adds all missing entries into table as commented out entries. LIN/PLA/GEN values are taken from other architectures and can be wrong as this was not tested.

Reproducible: Always
Comment 1 Marcin Juszkiewicz 2016-10-19 15:52:45 UTC 
Created attachment 101645 [details]
patch which adds all entries
Comment 2 Marcin Juszkiewicz 2016-10-19 15:53:08 UTC 
Created attachment 101646 [details]
patch which reformats table
Comment 3 Marcin Juszkiewicz 2017-02-07 18:41:56 UTC 
https://github.com/hrw/valgrind/commits/aarch64/reorder-syscalls-table branch takes care of it in nicer way.
Comment 4 Ivo Raisr 2017-05-05 15:29:03 UTC 
Marcin, what is the actual status here? Are the patches ready?
Comment 5 Marcin Juszkiewicz 2017-05-05 15:43:32 UTC 
patches got merged
Comment 6 Ivo Raisr 2017-05-05 15:55:52 UTC 
What do you mean by "merged"? Have they actually landed in Valgrind SVN? What was the SVN revision, then?
Comment 7 Marcin Juszkiewicz 2017-05-05 16:04:50 UTC 
16230 added missing entries
16231 removed bogus part of file
16232-16247 enabled several aarch64 syscalls
16248 marked not implemented as such

table looks ok now, is properly sorted, has entries updated
Comment 8 Ivo Raisr 2017-05-05 16:09:24 UTC 
Thank you for clarification. This bug has not been updated properly previously.