Created attachment 101609 [details] Screenshot The Breeze Dark Schema has some contrast issues. Comments are pretty hard to read in general, but with highlighting for the current line, it becomes extra hard. Additionally, the highlighting of email addresses (and other stuff between <…>) inside comments is rendered as black text, making it almost impossible to read. I added a screenshot demonstrating these contrast issues.
I would suggest making the comment color a little lighter and highlight all docblock comments in green instead of gray. Certain tags in doc comments are already green, why not make everything that color to distinguish doc comments from normal comments (similar to IntelliJ's Darcula theme)? Tags could then either be bold, italics or just a little brighter in color. The same could work for the stuff within angle brackets (instead of unreadable black).
Git commit b465dc8b96d4fa28cc4aa4309c190b89297948b7 by Dominik Haumann. Committed on 24/10/2016 at 19:21. Pushed by dhaumann into branch 'master'. Breeze (Dark): Make comments a bit lighter for better readability Increase from rgb(96, 96 96) to rgb(122, 124, 125), increases readability especially when screen brightness is low. FIXED-IN: KDE Frameworks 5.28 M +1 -1 src/data/katesyntaxhighlightingrc http://commits.kde.org/ktexteditor/b465dc8b96d4fa28cc4aa4309c190b89297948b7
The email address highlighting issue was already fixed here: https://bugs.kde.org/show_bug.cgi?id=363186 Btw, the comments intentionally have a bit less contrast, so that one can easily distinguish between code and comments. This also includes the colors that are used for things like @param or similar special comment characters. I'd rather not change this, since it already was a lot of work to get to this state. Could you please test the changed version (you can manually set the comments color to rgb(122, 124, 125) as mentioned above)? It should already be better.
Git commit 65c55459084083560e785f41feaf8712e7f960a7 by Dominik Haumann. Committed on 24/10/2016 at 19:29. Pushed by dhaumann into branch 'master'. Breeze (Dark): Make comment color a bit lighter for better readability M +1 -1 data/themes/breeze-dark.theme http://commits.kde.org/syntax-highlighting/65c55459084083560e785f41feaf8712e7f960a7
That's a little better. I think for normal text it's okay. But the issue with the current line still persists. The current line color is #3f3b51 and that makes comments very hard to read, even with the new color.
The current-line-color is #31363b, following the Breeze colors defined here: https://community.kde.org/KDE_Visual_Design_Group/HIG/Color So the background color itself follows the "alternat background color" of the KDE Default Breeze Dark scheme. I'm not yet convinced yet changing the entire color to e.g. green or so...
Strange, I had a different color, although I haven't changed anything. With #31363b it's a little better, but not optimal. I would make the current line color darker.
Ok, what would you say to the middle of both colors: #2A2E32 = rgb(42, 46, 50) for the current-line-color? Looks like a good compromise to me, do you agree?
Yeah, that looks fine.
Git commit 5a3dabd93619f5fab60517997f07d889b1f9630c by Dominik Haumann. Committed on 24/10/2016 at 20:15. Pushed by dhaumann into branch 'master'. Breeze Dark: Darken current-line background color for better readability M +1 -1 src/data/kateschemarc http://commits.kde.org/ktexteditor/5a3dabd93619f5fab60517997f07d889b1f9630c