Bug 370534 - options are ignored (for instance, --src-only causes a malfunction and no package is downloaded)
Summary: options are ignored (for instance, --src-only causes a malfunction and no pac...
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: Git
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-12 09:53 UTC by tcanabrava
Modified: 2016-10-14 02:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 16.11


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tcanabrava 2016-10-12 09:53:14 UTC
git bisect tells me that c9d32735a is the bad commit, anything below that commit I can do ./kdesrc-build --src-only (that I actually use it a lot just to update the sources and see if there's anything > 10 files, so I compile only them)


Reproducible: Always

Steps to Reproduce:
1. run ./kdesrc-build --src-only


Actual Results:  
kdesrc-build quits with a sad smiley

Expected Results:  
kdesrc-build should download all the sources.

using git master on arch linux.
Comment 1 Michael Pyne 2016-10-14 01:11:06 UTC
Sorry, taking a look now
Comment 2 Michael Pyne 2016-10-14 02:33:43 UTC
Git commit 17d282376de438bacdc5730f8e89d95e3a6fce90 by Michael Pyne.
Committed on 14/10/2016 at 02:28.
Pushed by mpyne into branch 'master'.

kde-projects: Fix a bug where some cmdline options were ignored.

Though I admit that I don't yet fully understand why the bug was
present, this seems to fix the use of options like --src-only. There was
an actual bug here: command line options are supposed to override
rc-file options by default, so the call to update the global context
object's options had to happen after the rc-file options were read.

Whatever *this* the problem was, it appears to have been related to
either the generation of the list of potential modules, or the filtering
of that list aftewards.

If other problems are encountered please reopen.
FIXED-IN:16.11

M  +4    -6    modules/ksb/Application.pm

http://commits.kde.org/kdesrc-build/17d282376de438bacdc5730f8e89d95e3a6fce90