Bug 370499 - bug in FindFFmpeg.cmake
Summary: bug in FindFFmpeg.cmake
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kfilemetadata
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.27.0
Platform: Compiled Sources All
: NOR normal
Target Milestone: ---
Assignee: Pinak Ahuja
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-11 19:57 UTC by RJVB
Modified: 2018-10-14 16:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2016-10-11 19:57:58 UTC
There's a typo causing a bug in FindFFmpeg.cmake that causes it to consider libpostproc "not found" even if it's installed.

Reproducible: Always

Steps to Reproduce:
configure kfilemetadata with a compatible FFMpeg installed

Actual Results:  
libpostproc is considered not available

Expected Results:  
all installed FFMpeg components should be found

--- cmake/orig.FindFFmpeg.cmake	2016-10-11 21:21:21.000000000 +0200
+++ cmake/FindFFmpeg.cmake	2016-10-11 21:49:52.000000000 +0200
@@ -124,7 +126,7 @@
   find_component(AVDEVICE libavdevice avdevice libavdevice/avdevice.h)
   find_component(AVUTIL   libavutil   avutil   libavutil/avutil.h)
   find_component(SWSCALE  libswscale  swscale  libswscale/swscale.h)
-  find_component(POSTPROC libpostproc postproc libpostproc/postprocess.h)
+  find_component(POSTPROCESS libpostproc postproc libpostproc/postprocess.h)
 
   # Check if the required components were found and add their stuff to the FFMPEG_* vars.
   foreach (_component ${FFmpeg_FIND_COMPONENTS})
Comment 1 Alexander Stippich 2018-10-14 10:55:50 UTC
This is fixed with the current version of KFileMetaData, it was probably forgotten to close this bug.
Comment 2 RJVB 2018-10-14 13:28:22 UTC
Fixed in the *current* version, over 20 releases later? Wow, that redefines certain concepts...

And no, I didn't forget to close the ticket. I completely forgot it was there - and since I've long stopped having the time to follow each point release of the crazy KF5 cycle it would still be a while before I discovered that my patch no longer applied.
Comment 3 Alexander Stippich 2018-10-14 13:34:47 UTC
I should have been more precise. I just went over some of the bug reports in KFileMetaData in order to clean them up a little bit. I looked at your patch and noticed that the changes are already in. So I really don't know who did it or when that fix was made, but it's there.
Comment 5 RJVB 2018-10-14 16:31:00 UTC
Indeed - didn't I imply something about my memory ;)