Bug 370337 - Dissolve for slideshow clip doesn't work if its parameter's value changed from default value (1s)
Summary: Dissolve for slideshow clip doesn't work if its parameter's value changed fro...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (show other bugs)
Version: 16.08.1
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-09 10:17 UTC by Alex Ander
Modified: 2016-12-02 15:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot from settings (78.64 KB, image/png)
2016-10-09 10:17 UTC, Alex Ander
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Ander 2016-10-09 10:17:45 UTC
Created attachment 101494 [details]
Screenshot from settings

I added a Slideshow clip to project. Turned on "dissolve" transition. The parameter's value was default (1s). I started preview. There were transition between slides. Then I changed that parameter to 2s. Started preview again. And then there were no transitions between slides at all. Changing it back to 1s didn't help.

I've started a thread about it there: https://forum.kde.org/viewtopic.php?f=270&t=136486
Comment 1 Martin 2016-11-29 14:42:43 UTC
one problem with the slideshow transition duration might be, that when the slideshow is created the property "luma_duration" is set to a value in the timecode but when the producerqueue sets the "duration" property for the luma filter it just grabs that timecode as a string and then calls .toInt() which seems to result in the duration being "0".

[from src/mltcontroller/producerqueue.cpp, lines 531 and 533]
QString luma_duration = EffectsList::property(info.xml,QStringLiteral("luma_duration"));
if (!luma_duration.isEmpty()) filter->set("duration", luma_duration.toInt());
Comment 2 Jean-Baptiste Mardelle 2016-12-02 15:10:34 UTC
Git commit 55d2e159ab53b32a280032dee65510027556ff70 by Jean-Baptiste Mardelle.
Committed on 02/12/2016 at 15:09.
Pushed by mardelle into branch 'Applications/16.12'.

Fix dissolve in slideshow clips broken

M  +1    -1    src/bin/bin.cpp
M  +9    -3    src/bin/projectclip.cpp
M  +1    -1    src/dialogs/clipcreationdialog.cpp
M  +0    -1    src/mltcontroller/producerqueue.cpp

https://commits.kde.org/kdenlive/55d2e159ab53b32a280032dee65510027556ff70