Bug 370281 - Lock screen notification label sometimes wraps over when it shouldn't
Summary: Lock screen notification label sometimes wraps over when it shouldn't
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Theme packages (show other bugs)
Version: 5.8.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-08 04:39 UTC by Pritam Baral
Modified: 2016-10-09 23:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pritam Baral 2016-10-08 04:39:31 UTC
When I feed the wrong password, the "Unlocking failed" message wraps over to a new line while there is plenty of space in the first line itself. The text is also left-aligned instead of being center-aligned, which gives it a bad appearance.

The behaviour doesn't happen on all fonts and font sizes. My system uses Oxygen at size 8 with a forced DPI of 120 (it's a 12.5" screen). If I change any of these three factors, it renders okay. On some rare conditions, it wraps over.

Reproducible: Sometimes

Steps to Reproduce:
1. Use a 1366x768 resolution at a forced font DPI of 120
2. Use Oxygen as the system font at a size of 8
3. Feed the wrong password at the lock screen

Actual Results:  
As shown in this image: http://imgur.com/Iw0qJzT

Expected Results:  
The text message "Unlocking failed" should appear in one line, since there's plenty of room there, and should be center-aligned.
Comment 1 Pritam Baral 2016-10-08 04:57:28 UTC
Patch submitted for review: https://phabricator.kde.org/D2984
Comment 2 David Edmundson 2016-10-09 23:14:42 UTC
Git commit e26c52414600c34078445aa2b2d3e450a2a44a6b by David Edmundson, on behalf of Pritam Baral.
Committed on 09/10/2016 at 23:14.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Center the notification label on Breeze's lockscreen

and make it use the full width before wrapping

Test Plan:
Tested on the same system that reported the bug; works for all
combinations of font, font size and DPI tested.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, jensreuterberg, pritambaral, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2984

M  +2    -0    lookandfeel/contents/components/SessionManagementScreen.qml

http://commits.kde.org/plasma-workspace/e26c52414600c34078445aa2b2d3e450a2a44a6b