Bug 370093 - Opening a picture (double-click) in Showfoto (default viewer) does not show the other pictures in the folder (similar to Bug 221245)
Summary: Opening a picture (double-click) in Showfoto (default viewer) does not show t...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Showfoto-Directory (show other bugs)
Version: 6.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-05 14:50 UTC by FabRic
Modified: 2022-02-05 05:33 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description FabRic 2016-10-05 14:50:45 UTC
I installed digiKam-5.2.0-02-Win64.exe on Windows 10 64 bits (version 1607 - Anniversary Update) and the described problem in the title here is (still) happening.

It was already there with digiKam 5.1.0 (and Windows 10 version 1511). Opening a picture with Showfoto does not show any of the other pictures in the folder, only the picture I double-clicked to open it in Showfoto (configured as default image viewer).

Also, the "Color", "Enhance", "Decorate" and "Effects" menus are not available / opening / scrolling.

FabRic

Reproducible: Always

Steps to Reproduce:
1. Double-click a picture file in Windows Explorer > It starts showfoto.exe and display that picture. OK.
2. The 'Thumbbar' is active but is only displaying the picture that was double-clicked, so you have to...
3. Click the 'Open folder' button in the 'Toolbar', browse to the picture folder, select it and open it.

This is working as expected but it would be nice to enable that picture viewer behaviour by default when opening Showfoto by double-clicking a file.



Also - and being a new user I don't know if there could be a reason why those are not enabled but - the "Color", "Enhance", "Decorate" and "Effects" menus are not available / opening / scrolling.

It is probably a completely different issue, though ; I hope it's not on my computer only.
Comment 1 Ahmed Badr 2016-10-24 10:26:43 UTC
This used to be the default behavior in old versions of showfoto and made it very usable as the default photo viewer in KDE. 
Please bring back this "feature".

Thanks
Comment 2 FabRic 2017-03-20 23:42:38 UTC
Still the same problem with digikam 5.5.0

(the menus - Color, Enhance, Decorate, Effects - are OK, though)
Comment 3 David Shen 2017-05-22 13:40:59 UTC
I am on Linux platform, and I got the same behavior. And the "Open Folder" button does not default to current image's folder, instead, it remember the last opening location. Also, there's no way to copy-paste current image's location.

This design has make this tool rather useless in most day to day usage scenario.
Comment 4 Maik Qualmann 2017-05-22 16:55:48 UTC
Gilles,

What do you think we should change the behavior? An "Open" option in the menu would then be enough.

Maik
Comment 5 caulier.gilles 2017-05-23 08:30:21 UTC
Maik,

I don't understand where is the problem here. I think we don't need more option.

"File/Open" will open one file as expected.

"File/Open folder" will open all images from the folder as FabRic want.

So use the right File menu option depending of the context.

Note : it work also in CLI. if you pass an image it will open just the image. If you pass a directory, it will open all image in this directory.

Gilles
Comment 6 Maik Qualmann 2017-05-23 17:16:13 UTC
I think the user wants to open an image and in the thumbnail bar always all images of the directory are to be displayed. It would not matter if you open a folder or a image, only one "Open" option.

Maik
Comment 7 caulier.gilles 2017-05-23 19:56:40 UTC
In this case, an option is Showfoto Setup dialog must be fine to use this behavior while an image is open from a directory.

Gilles
Comment 8 Maik Qualmann 2018-01-16 12:22:18 UTC
*** Bug 389047 has been marked as a duplicate of this bug. ***
Comment 9 FabRic 2018-09-23 00:45:40 UTC
As far as I can see, the option Gilles Caulier is talking about in his last post from may 2017 - which I think would solve the problem / feature request, here - still doesn't exist in Showfoto 6.0.0-beta1.

Any chance to see it appear before the next digiKam final release ?
Comment 10 Maik Qualmann 2018-09-23 11:48:27 UTC
The question for me is, do we really want an extra option in the setup?
I would suggest just an "Open..." entry in the menu:

When a directory has been selected, load all images of the directory and display the first image.

When an image has been selected, load all the images in the directory and display the selected image.

Maik
Comment 11 caulier.gilles 2018-09-23 14:49:00 UTC
Right.

File/Open Folder action already exists and do the job for the directory.
File/Open is to load just one file.

Why 2 separated action ? because the file open dialog need to know which kind of file it need to open (at least, it's a legacy from KFileDialog). I'm not sure if we can mix both at the same time with QFileDialog. If yes, you have the solution.

Gilles Caulier
Comment 12 Maik Qualmann 2018-09-23 16:44:00 UTC
You're right, Gilles, it works only file or directory. Probably only a very deep hack in the QFileDialog, which probably would not work with the native file dialog anymore.

Other strategy, via the command line is still possible both a directory or file. In the menu only "Open File..." that always loads the entire directory.

Maik
Comment 13 FabRic 2018-09-24 13:29:13 UTC
Would that also work when opening Showfoto by double-clicking on a file directly in the file manager (e.g. Windows Explorer), with Showfoto as the 'Picture Viewer' application by default for 'image' file types ?

Just asking because that's the requested behaviour in the bug description... :)

FabRic
Comment 14 Maik Qualmann 2018-09-25 20:17:14 UTC
Git commit 867bd1d9e346ce2763390c830a58dc66d0798735 by Maik Qualmann.
Committed on 25/09/2018 at 20:15.
Pushed by mqualmann into branch 'master'.

change the file open behavior of Showfoto
- single file selected, opens the whole directory
- two or more files selected, opens only these files
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +220  -212  core/showfoto/main/showfoto.cpp
M  +2    -3    core/showfoto/main/showfoto.h
M  +0    -2    core/showfoto/main/showfoto_p.h
M  +3    -3    core/showfoto/main/showfoto_setup.cpp
M  +1    -1    core/showfoto/thumbbar/showfotodragdrophandler.cpp
M  +1    -1    core/showfoto/thumbbar/showfotodragdrophandler.h

https://commits.kde.org/digikam/867bd1d9e346ce2763390c830a58dc66d0798735