Bug 370081 - Breeze GTK kconf update messes with downstream distribution settings
Summary: Breeze GTK kconf update messes with downstream distribution settings
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.7.5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-05 13:12 UTC by Rohan Garg
Modified: 2021-03-04 22:30 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rohan Garg 2016-10-05 13:12:08 UTC
The current update script from breeze-gtk seems to write out configs to the users config dir even when no configuration files are present in the home dir.

This totally breaks shipping custom configurations downstream. The update script should be fixed to accommodate OEM's setting a custom gtk theme.

Reproducible: Always

Steps to Reproduce:
1. Ship a custom config in /etc/gtk-3.0/settings.ini and /etc/gtk-2.0/gtkrc
2. Remove ~/.config/gtk-3.0/settings.ini and ~/.gtkrc-2.0
3. Edit ~/.config/kconf_updaterc to remove the GTKBreeze5.5 entry
4. Logout and Login

Actual Results:  
Files in the home dir are recreated overriding distro ones

Expected Results:  
Distro files should not be overridden unless explicitly configured by the user.
Comment 1 Jonathan Riddell 2016-10-05 13:18:11 UTC
"even when no configuration files are present" that's deliberate, but indeed it should consider distro settings in /etc
Comment 2 Rohan Garg 2016-10-05 13:18:56 UTC
That would be tricky to solve, what if a distro explicitly wants to use the oxygen theme?
Comment 3 Jonathan Riddell 2016-10-05 13:23:58 UTC
If the configuration file is present it shouldn't override it as I say
Comment 4 Janet Blackquill 2021-03-04 22:30:21 UTC
This  bug seems to be obsolete; we don't ship a KConf update script anymore and such a script's effects would probably be nullified by kde-gtk-config if it did exist.