Bug 369670 - activitymanager/ActivityItem.qml:77: ReferenceError: size is not defined
Summary: activitymanager/ActivityItem.qml:77: ReferenceError: size is not defined
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Activity Switcher sidebar (show other bugs)
Version: master
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 1.0
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-03 11:29 UTC by Elias Probst
Modified: 2016-10-03 14:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2016-10-03 11:29:56 UTC
When opening the ActivityManager, the following error is logged once per activity:
file:///usr/share/plasma/shells/org.kde.plasma.desktop/contents/activitymanager/ActivityItem.qml:77: ReferenceError: size is not defined

For reference: http://doc.qt.io/qt-5/qml-qtquick-image.html#sourceSize-prop

None of the activities shows a background thumbnail here - I wonder whether this is related?
Comment 1 David Edmundson 2016-10-03 12:32:14 UTC
It is a bug, but I don't think it's causing your lack of thumbnail, the code for the image providers handles the case of there being no source size and returns something arbitrary (which is the correct behaviour in that case)
Comment 2 Marco Martin 2016-10-03 12:50:26 UTC
the lack of thumbnail should be adressed at the latest thumbnail generation refactor, this is a separate issue.
Comment 3 Marco Martin 2016-10-03 14:34:02 UTC
Git commit 7cbcf46b332ef9c22306c5a628444cd81d0222b5 by Marco Martin.
Committed on 03/10/2016 at 14:33.
Pushed by mart into branch 'master'.

Image has width and height properties, not "size"

Summary:
this makes it actually do what it was intended to,
set the source size to the actual thumbnail size to keep a scaled
down texture in menory

Test Plan: normal usage, seems to work as expected, no warning

Reviewers: #plasma, sebas, davidedmundson

Reviewed By: #plasma, sebas, davidedmundson

Subscribers: davidedmundson, broulik, apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2919

M  +1    -1    desktoppackage/contents/activitymanager/ActivityItem.qml

http://commits.kde.org/plasma-desktop/7cbcf46b332ef9c22306c5a628444cd81d0222b5
Comment 4 Marco Martin 2016-10-03 14:34:48 UTC
Git commit 3d11772044470154530e41dd1cfb35031344ea4f by Marco Martin.
Committed on 03/10/2016 at 14:34.
Pushed by mart into branch 'Plasma/5.8'.

Image has width and height properties, not "size"

Summary:
this makes it actually do what it was intended to,
set the source size to the actual thumbnail size to keep a scaled
down texture in menory

Test Plan: normal usage, seems to work as expected, no warning

Reviewers: #plasma, sebas, davidedmundson

Reviewed By: #plasma, sebas, davidedmundson

Subscribers: davidedmundson, broulik, apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2919

M  +1    -1    desktoppackage/contents/activitymanager/ActivityItem.qml

http://commits.kde.org/plasma-desktop/3d11772044470154530e41dd1cfb35031344ea4f