Bug 369640 - Version control overlays not shown
Summary: Version control overlays not shown
Status: RESOLVED WORKSFORME
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: general (show other bugs)
Version: 16.08.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-02 15:19 UTC by Kai Uwe Broulik
Modified: 2020-11-24 04:34 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2016-10-02 15:19:38 UTC
I installed the git plugin and while the file label changes color (eg. becomes green) no overlays are shown in Dolphin. QPixmap DolphinFileItemListWidget::overlayForState(KVersionControlPlugin::ItemVersion version, int size) does return an overlay QPixmap (eg. vcs-normal" QPixmap(QSize(44, 44),depth=32,devicePixelRatio=2,cacheKey=0x738100000002), however.

Reproducible: Always

Steps to Reproduce:
1. Install dolphin-plugins
2. Enable "git" plugin
3. Navigate to a folder which is a git repository

Actual Results:  
No version control overlays are shown, only label color changes

Expected Results:  
Version control overlays are shown in addition to label color changes
Comment 1 Kai Uwe Broulik 2016-10-02 15:22:25 UTC
Oh, it's overlays in general, ie. symbolic links also don't get an overlay. It works in file dialogs, however. Re-assigning to Dolphin in general.
Comment 2 Matt 2016-10-20 05:33:20 UTC
I'm experiencing this as well. It happened to me once before on Arch Linux and now I see it's happening again on Gentoo using the live packages. I use nextcloud and I noticed the overlay icon only shows on one folder, then I also realized the symbolic link overlay icons were missing as well. Last time it happened to me I made a new user and saw that the bug was gone, so it's something in the user home directory that's causing the issue. I think I removed .cache, .config, and perhaps even .local and the issue went away. Just recently installed Gentoo and now I see that problem is back again. Hopefully someone can narrow it down a bit more so I don't have to shotgun blast all of my configuration files again.
Comment 3 Justin Zobel 2020-10-25 00:20:53 UTC
Can you please confirm this still occurs in a recent version of Dolphin.
Comment 4 Bug Janitor Service 2020-11-09 04:33:43 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2020-11-24 04:34:07 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!