Bug 369612 - Default SDDM avatars do not work with the theme
Summary: Default SDDM avatars do not work with the theme
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.7.95
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL: https://openqa.opensuse.org/tests/273...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-01 17:03 UTC by Fabian Vogt
Modified: 2018-09-16 16:02 UTC (History)
4 users (show)

See Also:
Latest Commit: https://cgit.kde.org/plasma-workspace.git/commit/?id=57385777cdff3b4fdb3816e1af87700004a85b99
Version Fixed In:
Sentry Crash Report:

Attachments
Workaround in the sddm theme (1.03 KB, patch)
2016-10-01 17:57 UTC, Fabian Vogt 		Details
Workaround in the sddm theme (1.04 KB, patch)
2016-10-07 20:10 UTC, Fabian Vogt 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2016-10-01 17:03:18 UTC 
The default SDDM avatars (.face.icon/root.face.icon) are dark transparent pngs and thus do not work on dark backgrounds.
So far the fallback to the "user-identity" icon worked only because of a bug in sddm 0.14.0: https://github.com/sddm/sddm/pull/684

Reproducible: Always
Comment 1 Fabian Vogt 2016-10-01 17:57:14 UTC 
Created attachment 101370 [details]
Workaround in the sddm theme

I attached a patch that works around the issue by replacing .face.icon and root.face.icon (the default sddm icons) with the plasma "user-identity" icon.
The proper fix is probably to expand sddm to support a per-theme "FacesDir=" configuration option and ship default faces with plasma-workspace.
Comment 2 Fabian Vogt 2016-10-07 20:10:12 UTC 
Created attachment 101478 [details]
Workaround in the sddm theme

The previous patch version was buggy, it also ignored the ".face.icon" files that users can put into their home directories. To only ignore the global sddm supplied onces, this now compares against a hardcoded sddm face path.