Bug 369480 - Preset choosing bugs: stylus tip-presets don't switch properly, / key broken
Summary: Preset choosing bugs: stylus tip-presets don't switch properly, / key broken
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-28 14:53 UTC by wolthera
Modified: 2016-10-14 08:53 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wolthera 2016-09-28 14:53:25 UTC
Both me an Animtim noticed that...

1. when Switching from normal stylus tip to backside and back again, the preset changes to the backside(eraser) preset, but doesn't change back.
2. The / key is broken.

Reproducible: Always
Comment 1 Halla Rempt 2016-10-03 09:05:50 UTC
https://phabricator.kde.org/T3893
Comment 2 Robert 2016-10-13 22:54:17 UTC
I am also experiencing this same bug with the git master build 3.0.90

I see the link Boudenwijn posted, but I have no idea how to apply it.
Comment 3 Robert 2016-10-13 22:54:47 UTC
I am also experiencing this same bug with the git master build 3.0.90

I see the link Boudenwijn posted, but I have no idea how to apply it.
Comment 4 Halla Rempt 2016-10-14 08:53:40 UTC
Git commit 62c4b49ba9876a6a1f62a3d5c1f264d19acd8eee by Boudewijn Rempt.
Committed on 14/10/2016 at 08:52.
Pushed by rempt into branch 'master'.

It's inevitable to do that check -- we have several preset selector
widgets, and selecting a preset, sets the current preset on all the other
widgets, which then emit a signal to tell the world the preset has been
changed. It would be good if that didn't happen, and it's possible to
achieve that by blocking signals, but that's not robust: it's always
possible something else selects a preset and starts the updating.

Closes T3893

M  +29   -24   libs/ui/kis_paintop_box.cc
M  +5    -5    libs/ui/kis_paintop_box.h
M  +0    -1    libs/widgets/KoResourceItemChooser.cpp

http://commits.kde.org/krita/62c4b49ba9876a6a1f62a3d5c1f264d19acd8eee