Bug 369443 - Unable to navigate in layer stack past any mask layer via hotkey
Summary: Unable to navigate in layer stack past any mask layer via hotkey
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: 3.0.1
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-27 19:48 UTC by rvz3366
Modified: 2016-10-10 21:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
test document (535.74 KB, application/x-krita)
2016-09-28 09:29 UTC, Halla Rempt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description rvz3366 2016-09-27 19:48:02 UTC
Any mask layer is dead stop in stack while navigating via hotkeys next/previous layer. If hotkey is pressed for autorepeating it can skim through mask layers.

Reproducible: Always

Steps to Reproduce:
1. Create mask layer.
2. Try to navigate through it in layer stack via activate next/previous layer hotkeys.
3. Hotkeys stop working when mask layer (Transparent, Transform, Filter mask, Local selection)  is selected.


Expected Results:  
It should be possible to navigate through mask layers via hotkeys.
Comment 1 Halla Rempt 2016-09-28 09:28:15 UTC
Hi,

I can confirm the issue. It doesn't seem to always happen, and never if the layerbox itself has focus, and there are more weird issues. I'll make a phabricator task.
Comment 2 Halla Rempt 2016-09-28 09:29:26 UTC
Created attachment 101326 [details]
test document

Observations:

* if the cursor is over the canvas, trying to go down with PgDn from the top stops at the filter mask
* If the cursor is over the layer box, the when going down from the filter mask, the Layer1 layer is activated, not Layer4 as should happen.
Comment 3 Halla Rempt 2016-09-28 09:30:57 UTC
https://phabricator.kde.org/T3888
Comment 4 Nicholas LaPointe 2016-10-10 21:59:12 UTC
Git commit 519be643a95c4311b7342a8b88615619598c555f by Nicholas LaPointe.
Committed on 10/10/2016 at 21:38.
Pushed by nicholasl into branch 'master'.

Fix PgUp/PgDn on layer stack

Switch the activation flags for activateNextLayer and activatePreviousLayer from KisAction::ACTIVE_LAYER to KisAction::ACTIVE_NODE.
ACTIVE_LAYER makes these actions only activate on nodes that inherit from KisLayer, which results in incorrect behavior when the active node is a mask.
Differential Revision: https://phabricator.kde.org/D3010

M  +2    -2    krita/krita.action

http://commits.kde.org/krita/519be643a95c4311b7342a8b88615619598c555f