Bug 369404 - drag and drop to chromium doesn't work
Summary: drag and drop to chromium doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords:
: 371409 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-09-26 21:49 UTC by Sebastian Kügler
Modified: 2018-02-13 23:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Kügler 2016-09-26 21:49:35 UTC
Dragging the screenshot from spectacle into chromium doesn't work, chromium doesn't recognize the mimedata correctly. It's broken for me in at least wordpress's media editor and imgur's uploader. It works fine with firefox.

Apparently, chromium struggles with the image attached to the mimedata in SpectacleCore.cpp When I comment the setImageData(...) call in  SpectacleCore::doStartDragAndDrop() it works.

I don't know which apps read the pixmap from the mimedata directly, so I dunno what this is going to break. I'm posting this bugreport for further discussion how to proceed.



Reproducible: Always
Comment 1 Boudhayan Gupta 2016-10-25 20:18:40 UTC
Has there been any changes in Chromium to fix this behaviour?

If there hasn't, let's get this fixed in time for Applications 16.12., either way (this might entail dropping attached Image Data, as you did).
Comment 2 Sebastian Kügler 2016-11-03 12:31:13 UTC
I'm running Chromium from Debian unstable, so it's a recent version (53). I'm not aware of any fixes in Chromium.

Do you want me to push my fix? (It's just removing the mimeData->setImageData(...) line)
Comment 3 Nate Graham 2018-01-31 05:09:52 UTC
Please feel free to push a fix, Sebastian!
Comment 4 Nate Graham 2018-01-31 05:10:21 UTC
*** Bug 371409 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2018-02-10 16:35:27 UTC
Patch available: https://phabricator.kde.org/D10427

Did a bunch of testing; nothing broke.
Comment 6 Nate Graham 2018-02-13 23:27:41 UTC
author	Nathaniel Graham <pointedstick@zoho.com>
committer	Nathaniel Graham <pointedstick@zoho.com>
commit	6742051c6bf545475d4f6dd67629b2abe8462b8c (patch)
tree	f50684bc45092dec3243a44b653d0d416d33cbad
parent	2b1c8bec0fd1ff6b929eca638264d0649270af5f (diff)
Fix drag-and-drop to ChromiumHEADmaster
Summary: BUG: 369404

Test Plan:
Tested in KDE Neon:
- Drag-and-drop to Chromium window works now
- Drag-and-drop to Firefox window still works
- Drag-and-drop to the Desktop still works
- Drag-and-drop to Dolphin window still works
- Drag-and-drop to GIMP window still works
- Drag-and-drop to Gwenview window still works

Reviewers: #spectacle, sebas, rkflx

Reviewed By: rkflx

Subscribers: rkflx

Differential Revision: https://phabricator.kde.org/D10427
Diffstat
-rw-r--r--	src/SpectacleCore.cpp	1	
		
1 files changed, 0 insertions, 1 deletions