Bug 369401 - In file preview, default focus should be inside the text field
Summary: In file preview, default focus should be inside the text field
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: 16.08.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ragnar Thomsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-26 21:03 UTC by G360
Modified: 2016-09-27 09:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 16.08.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description G360 2016-09-26 21:03:36 UTC
The preview can be closed with Esc or Alt+F4. Right now, one has to change focus with tab or pointer, to be able to search in the text. 

Having focus by default inside the text field would improve this situation. And closing the preview still can be done at once with different methods. 

Reproducible: Always

Steps to Reproduce:
1. Open archive with Ark
2. Open file for preview

Actual Results:  
Focus is on the Close button.

Expected Results:  
Focus to be inside the text view
Comment 1 Ragnar Thomsen 2016-09-27 09:45:37 UTC
Git commit 0ec7aa626901c9349f2ba8f878f35f7748b125e5 by Ragnar Thomsen.
Committed on 27/09/2016 at 09:43.
Pushed by rthomsen into branch 'Applications/16.08'.

Improve focus handling of internal previewer

This diff sets the initial focus of the internal previewer to the Part
widget and sets the autodefault property of the Close button to false.
The latter prevents the Enter key from closing the dialog which allows
the Part widget to handle the key press event instead.
Related: bug 369390
FIXED-IN: 16.08.2

M  +6    -1    part/arkviewer.cpp

http://commits.kde.org/ark/0ec7aa626901c9349f2ba8f878f35f7748b125e5