Bug 369242 - Services that can be executed are shown in Kicker with empty buttons
Summary: Services that can be executed are shown in Kicker with empty buttons
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.7.5
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-23 12:57 UTC by Olivier Churlaud
Modified: 2016-09-24 12:19 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Churlaud 2016-09-23 12:57:28 UTC 
See here: http://ctrlv.in/851402

Above Telegram and below Skype are respectively the Color KCM and the Autostart KCM. This happens because they are not Type=Application but Service and they have a Exec=...

I found out that in recentusagemodel.cpp, in function 

`QVariant RecentUsageModel::appData(const QString &resource, int role) const`

commenting 

    if (!service || !service->isApplication()) {
        return QVariant();
    }

solved the issue.

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-09-23 13:00:22 UTC 
As per Desktop Entry Specification [1] the "Exec" key is only allowed for "Type=Application". This is an application bug imho and they should  be completely filtered out, not just shown as empty entry.

[1] https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
Comment 2 Olivier Churlaud 2016-09-23 14:47:10 UTC 
Patch here : https://phabricator.kde.org/D2846