Bug 369195 - Consider Djvu files as documents
Summary: Consider Djvu files as documents
Status: RESOLVED FIXED
Alias: None
Product: frameworks-baloo
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Pinak Ahuja
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 13:51 UTC by Chris
Modified: 2017-10-31 02:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris 2016-09-22 13:51:59 UTC
When I do "find" in Dolphin and then select "Documents", I've got Pdf files but not Djvu files. Djvu files might nowadays be considered as some sort of alternative for pdf files; they might be searchable, or not, but so are pdf files.

I wish djvu files could be considered as documents.

I suppose it is the right product to fill the bug because in the past the request "search:/documents" was transmitted to Nepomuk which functionalities should now be in Baloo.

Also there is a commit from 2013:
http://quickgit.kde.org/?p=baloo.git&a=commitdiff&h=2e3076f8094b6fe7dce2077033698847a709bb80
"Consider text files as documents", which is a hint in this direction.

(kw: kde plasma dolphin find search document pdf djvu nepomuk baloo file)

Reproducible: Always
Comment 1 Nate Graham 2017-10-27 20:45:14 UTC
I've submitted a patch for this: https://phabricator.kde.org/D8528
Comment 2 Nate Graham 2017-10-31 02:26:19 UTC
Git commit 2e80367435ccb268239383d4f9934f15834db9a1 by Nathaniel Graham.
Committed on 31/10/2017 at 02:26.
Pushed by ngraham into branch 'master'.

Consider DjVu files to be documents

Summary:

Based on the Wikipedia page (https://en.wikipedia.org/wiki/DjVu), it seems reasonable to consider DjVu files to be documents rather than images.

Test Plan:
Tested in KDE Neon. Compiled and deployed fine. .djvu files are now listed as Documents:

{F5453411}

Reviewers: vhanda, #frameworks, rkflx

Reviewed By: rkflx

Subscribers: rkflx, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D8528

M  +1    -0    src/file/basicindexingjob.cpp

https://commits.kde.org/baloo/2e80367435ccb268239383d4f9934f15834db9a1