Bug 369165 - JJ: An option in the existing context menu to add the image as file layer when dragging an image in open document
Summary: JJ: An option in the existing context menu to add the image as file layer whe...
Status: CLOSED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2016-09-21 16:52 UTC by Raghavendra kamath
Modified: 2018-03-25 19:05 UTC (History)
4 users (show)

See Also:
Latest Commit: https://commits.kde.org/krita/86f7c65485744474506398924ee53e8e94b02475
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2016-09-21 16:52:24 UTC 
This is a wish bug request for adding an option in the existing context menu to add the image as file layer when dragging an image in open document. When a user drags an image in the document he is presented with a context menu showing options such as
Insert as new layer
open in new document
etc. I request to add an entry to add the image to open document as a file layer.

Reproducible: Always
Comment 1 Halla Rempt 2016-09-21 19:30:12 UTC 
Good point, and would be easy enough to do.
Comment 2 Scott Petrovic 2016-09-22 13:44:56 UTC 
cool idea. I could see this be useful.
Comment 3 David Marquant 2016-12-11 21:03:08 UTC 
I have, implemented this feature, but have one question left.

Is it OK to assume no scaling or should the user be asked which scaling type to use?
Comment 4 Raghavendra kamath 2016-12-12 04:43:57 UTC 
When dragging and dropping the dropped image is in no-scale mode , so I guess keeping no-scale option for file layer too would be suitable for drag and drop.
Comment 5 Halla Rempt 2016-12-12 10:08:21 UTC 
Yes, I agree. And I'm looking forward to the patch!
Comment 6 Unknown 2016-12-12 13:16:25 UTC 
Git commit 86f7c65485744474506398924ee53e8e94b02475 by Boudewijn Rempt.
Committed on 12/12/2016 at 13:15.
Pushed by rempt into branch 'rempt/impex-refactoring'.

Patch by David Marquant. Thanks!

M  +17   -1    libs/ui/KisView.cpp

https://commits.kde.org/krita/86f7c65485744474506398924ee53e8e94b02475
Comment 7 Raghavendra kamath 2016-12-12 14:07:38 UTC 
thank you David Marquant and boud for this commit :D