Bug 369119 - Inconsistent Instant Preview Mode user interface/experience
Summary: Inconsistent Instant Preview Mode user interface/experience
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources macOS
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-20 18:24 UTC by Patrice Kouame
Modified: 2016-11-07 15:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrice Kouame 2016-09-20 18:24:47 UTC
The Instant Preview Mode (IP) is disabled when selecting a Filter brush with Gaussian effect (for example).  The check box in the panel goes dark with strike-thru text. Thereafter, selecting another brush does not necessarily reset the mode.  It stays disabled for all brushes.  Only tickling a parameter, like Size or Ratio in the Pixel brush for instance,  resets, it.  Not all parameters do this though.

Also, assuming the IP Mode menu item should always reflect the Brush engine panel setting (and vice-versa), it doesn’t. The menu item stays checked even though the brush engine settings say its off.

Finally, with IP Mode OFF (via menu), shouldn’t it be disabled for all brushes? No matter what brush setting is changed?

NOTE: My understanding of how IP mode works may be twisted.  Please advise if that's the case, but I didn't find the current workflow intuitive.


Reproducible: Always

Steps to Reproduce:
1. Just to be safe, cleared all of my krita settings
2. Open krita with a new document
3. Set Instant Preview (IP) Mode On (via menu)
3. Click the toolbar Brush Settings icon - IP is, by default, checked.
4. Cycle through some other brush engines to verify that IP is enabled/checked everywhere
5. Select Filter and IP is disabled (goes dark after a split second)
6. All other brush settings now have IP disabled
7. Select another brush and IP is re-enabled ONLY after selecting the right parameter (for Pixel, Size or Ratio does thr trick)



Expected Results:  
1. When switching to a non Filter brush, IP mode should be (re)enabled if its compatible 
2. The IP Mode menu setting should always reflect the current brush engine setting
Comment 1 Scott Petrovic 2016-10-19 13:43:11 UTC
I can confirm this.

When you select the filter brush preset in the editor, the "Instant Preview" checkbox gets disabled with a strike-through, permanently making that checkbox disabled until restart. Whatever is disabling it doesn't seem to have a check to re-enable when changing presets.

I am on windows 10  with version 3. 0.1.90
Comment 2 Dmitry Kazakov 2016-11-07 14:43:54 UTC
Git commit 8c5506fe319ab877343274fcd07c2c3266eaa681 by Dmitry Kazakov.
Committed on 07/11/2016 at 12:22.
Pushed by dkazakov into branch 'rempt/impex-refactoring'.

Cold init Lod Availability widget when switching presets

The problem is that we still store the semantics of the lod
availability in the *widgets*, not in the settings object itself.

One day it'll have to be refactored like we did for size, spacing
and other options.
Related: bug 371938
Fixes T4221
Ref T4250

M  +2    -0    libs/ui/widgets/kis_paintop_presets_popup.cpp

http://commits.kde.org/krita/8c5506fe319ab877343274fcd07c2c3266eaa681
Comment 3 Dmitry Kazakov 2016-11-07 15:17:00 UTC
Git commit 72ac1393994b0bae8b3154d3ddd08d950a05636a by Dmitry Kazakov.
Committed on 07/11/2016 at 15:16.
Pushed by dkazakov into branch 'krita/3.1'.

Cold init Lod Availability widget when switching presets

The problem is that we still store the semantics of the lod
availability in the *widgets*, not in the settings object itself.

One day it'll have to be refactored like we did for size, spacing
and other options.
Related: bug 371938
Fixes T4221
Ref T4250

M  +2    -0    libs/ui/widgets/kis_paintop_presets_popup.cpp

http://commits.kde.org/krita/72ac1393994b0bae8b3154d3ddd08d950a05636a