Bug 369109 - Untranslatable percent values in GUI
Summary: Untranslatable percent values in GUI
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.18.3 (KDE Applications 15.12.3)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-20 10:07 UTC by Burkhard Lück
Modified: 2016-09-20 13:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 2.20.80 (KDE Applications 16.11.80)
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2016-09-20 10:07:03 UTC
Menu Diagram->Zoom has untranslatable zoom values
umbrello/uml.cpp:
action->setText(QLatin1String(" &") + QString::number(zoom) + QLatin1Char('%')); //i18nc missing

see also https://bugs.kde.org/show_bug.cgi?id=330135
Comment 1 Ralf Habacker 2016-09-20 10:34:44 UTC
Git commit da0026a35568924aaa31902ca9920c1103200d9b by Ralf Habacker.
Committed on 20/09/2016 at 10:34.
Pushed by habacker into branch 'master'.

Fix 'Untranslatable percent values in GUI'.
FIXED-IN:2.20.80 (KDE Applications 16.11.80)

M  +1    -1    umbrello/uml.cpp

http://commits.kde.org/umbrello/da0026a35568924aaa31902ca9920c1103200d9b
Comment 2 Burkhard Lück 2016-09-20 12:52:11 UTC
The fix neither extracts the string into the catalog nor queries at runtime for the translation.
Please use e. g.:

i18nc("%1 percent value from 33 to 300", " &%1%", zoom)

thanks
Comment 3 Ralf Habacker 2016-09-20 13:54:09 UTC
Git commit 2baf5b0b05c3837ecd8d2e738b12223ee82d9af3 by Ralf Habacker.
Committed on 20/09/2016 at 13:53.
Pushed by habacker into branch 'master'.

Convert untranslated string into translatable string according to KDE rules.

M  +1    -1    umbrello/uml.cpp

http://commits.kde.org/umbrello/2baf5b0b05c3837ecd8d2e738b12223ee82d9af3