See screenshot: Quoted text in plain text view is rendered without any indication of how many quotation levels a line is nested. The following mail text results in the attached screenshot - try to keep an overview over a quoted mail with multiple quotation levels in multiple sections... It's impossible... The demo-mails content: Am Montag, 19. September 2016, 21:01:11 CEST schrieb Gunter Ohrner: > Am Montag, 19. September 2016, 21:00:44 CEST schrieb Gunter Ohrner: > > Am Montag, 19. September 2016, 21:00:25 CEST schrieb Gunter Ohrner: > > > Text Level 1 > > > > Text Level 2 > > Text Level 3 Text Level 4 Reproducible: Always
Created attachment 101186 [details] Screenshot with messed-up rendering of quoted text. (No indication of a line's quoting level.)
Git commit cea1557b67d87709091acdae49987e0278a7c384 by Montel Laurent. Committed on 03/10/2016 at 05:19. Pushed by mlaurent into branch 'Applications/16.08'. Fix Bug 369072 - Regression kMail 5.3.x: Plain-text quoting display is messed up FIXED-IN: 5.3.2 M +5 -0 messageviewer/src/messagepartthemes/default/defaultrenderer.cpp http://commits.kde.org/messagelib/cea1557b67d87709091acdae49987e0278a7c384
Unfortunately, the quoted parts still do not look correctly. You still cannot determine the context / quoting levels.
Created attachment 101597 [details] Screenshot showing the bug after the 5.3.2 patch.
In more detail: The mail is currently displayed as follows: Am Montag, 19. September 2016, 21:01:11 CEST schrieb Gunter Ohrner: | Am Montag, 19. September 2016, 21:00:44 CEST schrieb Gunter Ohrner: | Am Montag, 19. September 2016, 21:00:25 CEST schrieb Gunter Ohrner: | Text Level 1 Text Level 2 Text Level 3 Text Level 4 This does not really make sense and you still cannot determine that "Text Level 3" is an answer to "Text Level 2", but "Text Level 4" is not, and you also cannot determine that "Text Level 2" belongs to the introduction line from "21:00:44" and "Text Level 3" belongs to the introduction line from "21:01:11". You cannot even easily see that "Text Level 2" and 3 are quoted but "Text Level 4" is not. (Except possibly due to font face and color, if configured accordingly, which is applied correctly.) It should look as follows however to make clear which part belongs to what and what part is an answer to which: Am Montag, 19. September 2016, 21:01:11 CEST schrieb Gunter Ohrner: | Am Montag, 19. September 2016, 21:00:44 CEST schrieb Gunter Ohrner: | | Am Montag, 19. September 2016, 21:00:25 CEST schrieb Gunter Ohrner: | | | Text Level 1 | | Text Level 2 | Text Level 3 Text Level 4
Git commit c812e79789d6991fc011d8e93b46efec89ac4544 by Montel Laurent. Committed on 23/10/2016 at 19:21. Pushed by mlaurent into branch 'Applications/16.08'. Start to fix quoting display. Still not perfect. M +5 -5 messageviewer/src/messagepartthemes/default/defaultrenderer.cpp http://commits.kde.org/messagelib/c812e79789d6991fc011d8e93b46efec89ac4544
Git commit c1d1b7fb6ebeb6c060b172567aa6df9104a6aeed by Montel Laurent. Committed on 24/10/2016 at 19:03. Pushed by mlaurent into branch 'master'. Fix Bug 369072 - Regression kMail 5.3.x: Plain-text quoting display is messed up FIXED-IN: 3.4.0 M +2 -2 messageviewer/src/messagepartthemes/default/autotests/quotehtmltest.cpp M +0 -1 messageviewer/src/messagepartthemes/default/defaultrenderer.cpp http://commits.kde.org/messagelib/c1d1b7fb6ebeb6c060b172567aa6df9104a6aeed
I guess you meant version 5.3.4 - not 3.4.0?
Git commit 9c764eaa3995be89b3bcb94822ec9446d47a9b1c by Montel Laurent. Committed on 25/10/2016 at 04:49. Pushed by mlaurent into branch 'Applications/16.08'. Fix Bug 369072 - Regression kMail 5.3.x: Plain-text quoting display is messed up FIXED-IN: 3.4.0 (cherry picked from commit c1d1b7fb6ebeb6c060b172567aa6df9104a6aeed) M +2 -2 messageviewer/src/messagepartthemes/default/autotests/quotehtmltest.cpp M +0 -1 messageviewer/src/messagepartthemes/default/defaultrenderer.cpp http://commits.kde.org/messagelib/9c764eaa3995be89b3bcb94822ec9446d47a9b1c