Bug 369016 - Remove pixel on top of tab bar when menubar is off
Summary: Remove pixel on top of tab bar when menubar is off
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: 5.20.3
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2016-09-19 01:25 UTC by manuelchaves
Modified: 2021-11-09 18:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description manuelchaves 2016-09-19 01:25:32 UTC
I removed the menubar and put the tab bar on top. But there's a 1 pixel line on top of the tab bar that disables the users from clicking on a tab as easily since when the window is maximized you would expect the very top of the screen to have access to the tabs, but you have to move your mouse slightly lower.
Comment 1 Justin Zobel 2020-11-30 03:30:58 UTC
Can confirm this is still present.
Comment 2 Friedrich W. H. Kossebau 2020-11-30 10:04:05 UTC
This is an issue with the Breeze style it seems. That one calculates a region for the tab bar element in a QTabWidget which has a margin of 1 to the border:
see Style::tabWidgetTabBarRect() at https://invent.kde.org/plasma/breeze/-/blob/master/kstyle/breezestyle.cpp#L1893

And thus as result also means that a with a tabbar placed next to the screen border we do not get the infinite tabs which allow throwing the mouse against the screen edge and clicking the tab easily, but instead enforces to properly target them instead (something with Fitt's law and stuff).

With styles like Plastique, Windows or QtCurve that is not an issue.

I do not think we should try to workaround this in Konversation. Instead this is a principle issue with the Breeze style.

That 1 pixel margin seems wanted for design issues, to not blend the outshape lines with that of neighbouring elements I guess.

Yet to help with that case of screen edges, the active tab range should still include also that margin pixels IMHO.
Comment 3 manuelchaves 2020-12-01 07:47:14 UTC
This also affects Dolphin tabs.
Comment 4 Nate Graham 2021-11-09 18:45:05 UTC
Git commit eccfb7500503719651ea34a0b00b1dee2583a94f by Nate Graham, on behalf of Jan Blackquill.
Committed on 09/11/2021 at 18:44.
Pushed by ngraham into branch 'master'.

kstyle: make tabs flush against edges in QTabWidget

M  +27   -5    kstyle/breezestyle.cpp

https://invent.kde.org/plasma/breeze/commit/eccfb7500503719651ea34a0b00b1dee2583a94f