Bug 368974 - System Settings | App. Style | Window Decorations -> Breeze button size settings are incorrect
Summary: System Settings | App. Style | Window Decorations -> Breeze button size sett...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: window decoration (show other bugs)
Version: 5.7.95
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-17 19:52 UTC by Darin Miller
Modified: 2017-09-23 03:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Miller 2016-09-17 19:52:07 UTC 
When Using System Settings | App. Style | Window Decorations  -> Breeze button, the window decoration button resizing drop down used change all button sizes immediately upon  Apply.    Currently in 5.7.95, the height of the decoration bar changes, but the buttons themselves remain unchanged.  '

In a similar note, the Window Title font is not immediately updated either.

Restarting kwin_x11  applies the newly set button size and Window title font.

Reproducible: Always

Steps to Reproduce:
1. Settings | App. Style | Window Decorations  -> Breeze button
2. Change the Button Size drop down to something different.
3. Notice the title bar height changes slightly but button remain same size.  

Note: Using 4K (hdpi) display.

Actual Results:  
No changes in font size or button height until kwin_x11 is restarted.

Expected Results:  
Change should be immediate as it was before.
Comment 1 Hugo Pereira Da Costa 2016-10-04 09:42:17 UTC 
Confirmed.
Checking whether this is actually breeze or kdecoration
Comment 2 Hugo Pereira Da Costa 2016-10-04 09:44:03 UTC 
Note that here at least, resizing the window, makes the button size change visible (probably because of triggering a repaint of the decoration), this without restarting kwin.
Can you confirm ?
Comment 3 Hugo Pereira Da Costa 2016-10-04 10:28:17 UTC 
Git commit b5fd63ad24bca26d3357847996e2c9ec848efc84 by Hugo Pereira Da Costa.
Committed on 04/10/2016 at 10:24.
Pushed by hpereiradacosta into branch 'Plasma/5.8'.

Call updateButtonsGeometryDelayed on settings reconfigured, so that button sizes are updated immediately

M  +1    -0    kdecoration/breezedecoration.cpp

http://commits.kde.org/breeze/b5fd63ad24bca26d3357847996e2c9ec848efc84
Comment 4 Hugo Pereira Da Costa 2016-10-04 10:40:06 UTC 
Ok. That fixes the button size.
Not the font, but on my system (which is a mix of kde4 and plasma5, I cannot get the plasma5 fonts properly taken into account, and thus cannot confirm/test/fix the issue. Will try once I have a full plasma setup
Comment 5 Darin Miller 2016-10-05 02:16:49 UTC 
This problem still persists with the 5.8 updates on neon user edition.  I will check the dev-unstable shortly.
Comment 6 Darin Miller 2016-10-05 02:58:14 UTC 
Problem also persists in Plasma 5.8.9, but I suspect the update has not yet hit the repos... will check again in few days.  (Current Breeze package version is +git20161002.1318-0). 

Thanks!
Comment 7 Darin Miller 2016-10-08 15:27:29 UTC 
Verified fixed now.  YGAA (You guys are awesome!)
Comment 8 Hugo Pereira Da Costa 2016-10-08 15:47:23 UTC 
Thanks ! and thanks for reporting in the first place.