Bug 368897 - [PATCH] VHDL syntax highlighting error
Summary: [PATCH] VHDL syntax highlighting error
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-16 12:14 UTC by Alex
Modified: 2017-07-23 09:23 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.37


Attachments
Patch to syntax highlighting file vhdl.xml (1.33 KB, patch)
2017-07-21 19:53 UTC, Jan Michel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2016-09-16 12:14:58 UTC
parser problem when using brackets and attributes simultaneously:
A(A'high)  - parser error
A(A'high ) - no parser error(added space)
Comment 1 Christoph Cullmann 2017-06-25 11:48:34 UTC
Moving to syntax highlighting framework, we use the files from there now.
Comment 2 Dominik Haumann 2017-07-21 17:00:44 UTC
Add original authors to CC. Could you please look into this?
Comment 3 Jan Michel 2017-07-21 19:53:58 UTC
Created attachment 106784 [details]
Patch to syntax highlighting file vhdl.xml

You're right, closing parentheses were not handled correctly after attributes. A 'lookAhead' statement was missing. The patch fixes this, including correct handling of attributes with arguments.
Comment 4 Dominik Haumann 2017-07-23 08:11:35 UTC
Git commit ab8618bc922aebf950655e52a635bb1d358671d8 by Dominik Haumann.
Committed on 23/07/2017 at 08:11.
Pushed by dhaumann into branch 'master'.

VHDL: Fix highlighting error when using brackets and attributes

Thanks to Jan Michel for the patch!
FIXED-IN: 5.37

M  +6    -0    autotests/folding/light52_tb.vhdl.fold
M  +6    -0    autotests/html/light52_tb.vhdl.html
M  +6    -0    autotests/input/light52_tb.vhdl
M  +6    -0    autotests/reference/light52_tb.vhdl.ref
M  +7    -4    data/syntax/vhdl.xml

https://commits.kde.org/syntax-highlighting/ab8618bc922aebf950655e52a635bb1d358671d8