Bug 368833 - Incomplete and incorrect animation icons
Summary: Incomplete and incorrect animation icons
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL: https://quickgit.kde.org/?p=breeze-ic...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-15 06:58 UTC by Jorge Villaseñor
Modified: 2018-01-12 13:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jorge Villaseñor 2016-09-15 06:58:37 UTC
The icon Name Specification mentions the Animations context and specifically a process-working icon animation. I see from bug 360304 [1] that the icon was added, but it was added on the Status specification and it was only added for size 22 in this commit [2]. The index.theme file says that the minimum size for that context is 22 and max is 32. If the icon is needed on other sizes, say 16, it is not available.

A new context must be created "Animations" and the icon be placed on the different sizes.

[1] https://bugs.kde.org/show_bug.cgi?id=360304
[2] http://commits.kde.org/breeze-icons/6643933224061e775df22e7ba2b58eb51f7148df

Reproducible: Always

Steps to Reproduce:
I discovered this while migrating a gtk application so the steps are gtk specific, you can find it with other tools, even with dolphin.

1. Look up for the standard process-working animation with a GtkCellRendererPixbuf.
2. Leave the default icon size (16 px)

Alternative steps:
1. Go to /usr/share/icons/breeze/animations (icon not found)
2. Go to /usr/share/icons/breeze/status/16 (icon not found)
2. Go to /usr/share/icons/breeze/status/22 (icon found)

Actual Results:  
No icon was found.

Expected Results:  
The standard process-working animation should be loaded into the cell renderer.

First bug, not sure if you would have preferred me to comment on the other bug or open a new one. I decided to leave the other closed.
Comment 1 andreas 2018-01-09 12:02:37 UTC
in which folder should the process-working icon be located?
Comment 2 Jorge Villaseñor 2018-01-12 03:04:20 UTC
An animated one should be located on icons/breeze/animations, it would be good to have it on multiple sizes too. I'm interested on the 16x16 one.

And if a static version of it is wanted, it should be available on icons/breeze/status/16

As reference, I noticed the Oxygen theme has those icons.
Comment 3 andreas 2018-01-12 13:50:39 UTC
Git commit 495829b2b0fea458bfa01a996d23181d254e3521 by andreas kainz.
Committed on 12/01/2018 at 13:55.
Pushed by andreask into branch 'master'.

Update animation icons

A  +44   -0    icons-dark/animations/16/process-working.svg
C  +1    -1    icons-dark/animations/22/process-working.svg [from: icons/status/22/process-working.svg - 099% similarity]
M  +18   -1    icons-dark/index.theme
A  +44   -0    icons/animations/16/process-working.svg
R  +0    -0    icons/animations/22/process-working.svg [from: icons/status/22/process-working.svg - 100% similarity]
M  +18   -1    icons/index.theme

https://commits.kde.org/breeze-icons/495829b2b0fea458bfa01a996d23181d254e3521