Bug 368802 - git master 2016-09-14: Proxies not generated for .mlt files automatically.
Summary: git master 2016-09-14: Proxies not generated for .mlt files automatically.
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-14 12:22 UTC by Evert Vorster
Modified: 2016-09-17 16:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Project with the proxy correctly displaying (21.36 KB, application/x-kdenlive)
2016-09-17 12:05 UTC, Evert Vorster
Details
Project pointing to proxy as a clip (21.30 KB, application/x-kdenlive)
2016-09-17 12:08 UTC, Evert Vorster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2016-09-14 12:22:00 UTC
.mlt files in the project bin does not appear to get proxy clips. 
They are slower to draw on screen than normal footage, so the speed benefit here would be even more than a proxy for normal footage. 



Reproducible: Always

Steps to Reproduce:
1. Enable proxies on project
2. Load .mlt file in project bin


Actual Results:  
I can see a progress bar as if a proxy is generated, but the clip never gets a proxy. 
Putting the .mlt on the timeline results in very slow playback, even slower than just normal high resolution footage. 

Expected Results:  
A proxy to be generated for the the .mlt file, so that editing can be quick on the timeline. 
Original .mlt file to be used for final render.
Comment 1 Jean-Baptiste Mardelle 2016-09-14 19:32:18 UTC
Do you mean automatic creation of proxy? In my tests, I can left click on a .mlt clip in the project bin and ask a proxy, it works correctly. Can you give more details about how you expect the proxy to be build ?
Comment 2 Evert Vorster 2016-09-14 19:39:08 UTC
My project was set to automatic proxy generation. 

The mlt files do not automatically get a proxy, and I assumed that the proxy generation did not work at all for it. 

I will change the heading of this bug to automatic proxy generation for .mlt files do not work. 

I have just tested, and manual proxy generation does indeed work for .mlt files. 
Since proxy generation is a type of render, would it be too much to ask to put a render dialog in the clip jobs as well? I would really like to be able to render .mlt files, especially stabilize, to whatever resolution I choose, and add the output to the project automatically.... 

Thanks for looking into this one!
Comment 3 Evert Vorster 2016-09-17 11:44:25 UTC
A bit more information on this issue, not sure if it is related. 

When changing the proxy profile for a project where the project supports proxies, the proxies on the normal clips render as they should. 

However, the proxies on the .mlt files throw the following error:
ffmpeg version 3.1.3 Copyright (c) 2000-2016 the FFmpeg developers
  built with gcc 6.1.1 (GCC) 20160802
  configuration: --prefix=/usr --disable-debug --disable-static --disable-stripping --enable-avisynth --enable-avresample --enable-fontconfig --enable-gmp --enable-gnutls --enable-gpl --enable-ladspa --enable-libass --enable-libbluray --enable-libfreetype --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libmodplug --enable-libmp3lame --enable-libopencore_amrnb --enable-libopencore_amrwb --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-libschroedinger --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libv4l2 --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxvid --enable-netcdf --enable-shared --enable-version3 --enable-x11grab
  libavutil      55. 28.100 / 55. 28.100
  libavcodec     57. 48.101 / 57. 48.101
  libavformat    57. 41.100 / 57. 41.100
  libavdevice    57.  0.101 / 57.  0.101
  libavfilter     6. 47.100 /  6. 47.100
  libavresample   3.  0.  0 /  3.  0.  0
  libswscale      4.  1.100 /  4.  1.100
  libswresample   2.  1.100 /  2.  1.100
  libpostproc    54.  0.100 / 54.  0.100
/data/DigiKam/Video Clips Raw/Work/2016/06_Amu_North Sea/phone/20160609_082613.mp4.mlt: Invalid data found when processing input


The error message is similar to the error that is displayed when applying a clip job to an .mlt file.
Comment 4 Evert Vorster 2016-09-17 12:04:59 UTC
Some more digging... Seems that the proxy generator does not like my proxy profile, but only for the .mlt files, which is a bit weird. 

It creates the proxies fine with:
-s 640x360 -noautorotate -g 5 -crf 26 -ab 128k -vcodec libx264 -acodec libvorbis -preset ultrafast

But fails to create proxies for .mlt files with:
-s 320x180 -noautorotate -g 5 -crf 26 -ab 128k -vcodec libx264 -acodec libvorbis -preset ultrafast

When the proxy generator fails to create proxies, the yellow "P" is never removed from the icon of the clip.

If this file is then saved, the clips suddenly point to the proxy clips created in a previous pass, instead of pointing to the .mlt files used as original clips. 

I'll attach two projects showing this
Comment 5 Evert Vorster 2016-09-17 12:05:58 UTC
Created attachment 101137 [details]
Project with the proxy correctly displaying
Comment 6 Evert Vorster 2016-09-17 12:08:30 UTC
Created attachment 101138 [details]
Project pointing to proxy as a clip

This is the project where the clip in the project bin is pointing to the proxy file, rather than the .mlt file with proxy enabled. 

This only happens when the proxy profile is one that causes a failure or proxy generation.
Comment 7 Jean-Baptiste Mardelle 2016-09-17 12:33:42 UTC
Git commit 7f17407ae5b728a28dd376a3e2b823f7e56cfc9c by Jean-Baptiste Mardelle.
Committed on 17/09/2016 at 12:33.
Pushed by mardelle into branch 'master'.

Fix proxied playlist clips incorrectly detected as AV clips on document opening

M  +4    -1    src/mltcontroller/clipcontroller.cpp

http://commits.kde.org/kdenlive/7f17407ae5b728a28dd376a3e2b823f7e56cfc9c
Comment 8 Jean-Baptiste Mardelle 2016-09-17 12:35:20 UTC
Should be fixed now, please test and let me know if this doesn't cause other issues, then I will backport for 16.08.2
Comment 9 Jean-Baptiste Mardelle 2016-09-17 12:36:17 UTC
Oh, I mean the issue described in comment 3 is fixed, original problem still not fixed but should be easy...
Comment 10 Evert Vorster 2016-09-17 15:24:15 UTC
Ah, most issues have been fixed, apart from the actual automatic proxy generation. 

Good job so far! 

Sorry about putting a different issue into this report, it really should have been a seperate bug report.

Thanks for looking into this report!
Comment 11 Jean-Baptiste Mardelle 2016-09-17 15:54:29 UTC
Git commit f14fdfdd4ea7285eda64e3027936389efa3a9392 by Jean-Baptiste Mardelle.
Committed on 17/09/2016 at 15:52.
Pushed by mardelle into branch 'master'.

Automatically proxy playlist if enabled

M  +9    -4    src/bin/bin.cpp

http://commits.kde.org/kdenlive/f14fdfdd4ea7285eda64e3027936389efa3a9392
Comment 12 Evert Vorster 2016-09-17 16:26:13 UTC
Fixed!

Thank you so much for looking into this. 

:)